From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: Add new command to set USB 2.0 port test modes
Date: Tue, 19 Feb 2013 17:21:10 -0500 [thread overview]
Message-ID: <5123FAD6.3010200@ti.com> (raw)
In-Reply-To: <CAODwPW-RyJzThOMw3p9i=LkTt0hrJd+zufchMJyHii_YVeaTAw@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/19/2013 04:29 PM, Julius Werner wrote:
> Hi Tom,
>
> This patch is not really target specific, it works on all platforms
> that support USB 2.0. I just wrapped it in a new config option
> because most people probably won't need it? it is only really
> useful for hardware verification, so I figured whoever needs it can
> hack in the config option himself. However, I could also just
> remove the #ifdef and activate it by default if you prefer that. No
> new code will get executed unless you type the new command, so it
> should not have any negative effect besides a negligible code size
> increase.
Well, we should enable it at least on the board config you've tested
the code with, and you can show how negligible the size difference is.
The point is that adding code that's not enabled somewhere leads to
bitrot. Thanks!
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJRI/rVAAoJENk4IS6UOR1W5yoP/jA1KZaqH/1a+uiF4TkMhOqO
1ureFhSUBG875EqnqJsjdGgYt/SZfwBtku5i+qZDtE5jAN6KpPOEV4grRUAYhWll
dWpb503TK9Ow+sJKYk8KF+k+awyMwt60L2gZEYxtl2C8ZCGiC6MzEmA25W24pBKh
Vj3g6Sg5tgoFPWFBFFXtP3UNgcIzDrmSE4UJzyzKXInap4dwHt+b6Z6EwZ4+iQ6t
ekNYxMlEVgdmw2KeuGmDlvjQpmVpaavMYCEON6NbUuCeg830555ETxzC/k37obDq
K+PPITocXiR6dm8J42nBA1kaoaG58oRLjCSFlPogVxQ/VdtuAf2RhX9MOBofBw4j
VdyV4d90rTCMHdKqids71gdB2YxqkIVdschN7jjpeNHDUEk54dVB5dAW49UJmxhD
SWMF03YAfM055W4F0h2CsoZHr/hYqRwDo2J3ljazCAAsSfYav0kdaI6HzZI1zFmd
hjs+ThO3A3Ek+lGsSx3Gh0JKKGv/FyfstnrFMVpF098SNkblN7WP7BmCTcWD6ARq
h+GecKlSnguzuOVkDjuLCLgJnPVLY2m4D9ixaTuVMGDgNyFCiC4n/TRamHgG7duW
HgEyni0hgk3dV3YV9olFeNPaZv0DW+iF0dkQeUI61KfDl8Xi/2Vc4b0ds53NJQmQ
fR0w3/FsjQbksD2/aGac
=eCCl
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-02-19 22:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-16 1:52 [U-Boot] [PATCH] usb: Add new command to set USB 2.0 port test modes Julius Werner
2013-02-18 19:01 ` Tom Rini
2013-02-19 21:29 ` Julius Werner
2013-02-19 22:21 ` Tom Rini [this message]
2013-02-20 1:13 ` Julius Werner
2013-02-20 1:14 ` Julius Werner
2013-03-01 4:06 ` Julius Werner
2013-03-01 4:08 ` Julius Werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5123FAD6.3010200@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox