From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Nelson Date: Tue, 19 Feb 2013 18:16:51 -0700 Subject: [U-Boot] i.MX6: Add hdmidet command In-Reply-To: References: <5123DCB0.4030601@boundarydevices.com> <512404D1.5020600@boundarydevices.com> Message-ID: <51242403.1080709@boundarydevices.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 02/19/2013 05:42 PM, Otavio Salvador wrote: > On Tue, Feb 19, 2013 at 8:03 PM, Eric Nelson > wrote: >> Hi Otavio, >> >> >> On 02/19/2013 01:30 PM, Otavio Salvador wrote: >>> >>> On Tue, Feb 19, 2013 at 5:12 PM, Eric Nelson >>> wrote: >>>> >>>> Hi Stefano, >>>> >>>> This seems to have gotten lost in the shuffle. >>>> >>>> It's showing as "Changes requested" in Patchwork: >>>> >>>> http://patchwork.ozlabs.org/patch/186280/ >>>> >>>> Is there something you'd like changed? >>>> >>>> Please advise, >>> >>> >>> I'd say to use space between the '+' as done in other code. >>> >> >> I must be dense. >> >> Which '+' needs a space? > > It seems usually when dealing with offsets we have ' + '. Personally I > think it is clear to read too. But it's not my call so it is up to you > and Stefano. > Gotcha. You mean here: +{ + u8 reg = __raw_readb(HDMI_ARB_BASE_ADDR+HDMI_PHY_STAT0); ^ That's the trouble with commenting on the patchwork link... No context. Regards, Eric