* [U-Boot] i.MX6: Add hdmidet command
@ 2013-02-19 20:12 Eric Nelson
2013-02-19 20:30 ` Otavio Salvador
0 siblings, 1 reply; 8+ messages in thread
From: Eric Nelson @ 2013-02-19 20:12 UTC (permalink / raw)
To: u-boot
Hi Stefano,
This seems to have gotten lost in the shuffle.
It's showing as "Changes requested" in Patchwork:
http://patchwork.ozlabs.org/patch/186280/
Is there something you'd like changed?
Please advise,
Eric
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] i.MX6: Add hdmidet command
2013-02-19 20:12 [U-Boot] i.MX6: Add hdmidet command Eric Nelson
@ 2013-02-19 20:30 ` Otavio Salvador
2013-02-19 23:03 ` Eric Nelson
0 siblings, 1 reply; 8+ messages in thread
From: Otavio Salvador @ 2013-02-19 20:30 UTC (permalink / raw)
To: u-boot
On Tue, Feb 19, 2013 at 5:12 PM, Eric Nelson
<eric.nelson@boundarydevices.com> wrote:
> Hi Stefano,
>
> This seems to have gotten lost in the shuffle.
>
> It's showing as "Changes requested" in Patchwork:
>
> http://patchwork.ozlabs.org/patch/186280/
>
> Is there something you'd like changed?
>
> Please advise,
I'd say to use space between the '+' as done in other code.
--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] i.MX6: Add hdmidet command
2013-02-19 20:30 ` Otavio Salvador
@ 2013-02-19 23:03 ` Eric Nelson
2013-02-20 0:42 ` Otavio Salvador
0 siblings, 1 reply; 8+ messages in thread
From: Eric Nelson @ 2013-02-19 23:03 UTC (permalink / raw)
To: u-boot
Hi Otavio,
On 02/19/2013 01:30 PM, Otavio Salvador wrote:
> On Tue, Feb 19, 2013 at 5:12 PM, Eric Nelson
> <eric.nelson@boundarydevices.com> wrote:
>> Hi Stefano,
>>
>> This seems to have gotten lost in the shuffle.
>>
>> It's showing as "Changes requested" in Patchwork:
>>
>> http://patchwork.ozlabs.org/patch/186280/
>>
>> Is there something you'd like changed?
>>
>> Please advise,
>
> I'd say to use space between the '+' as done in other code.
>
I must be dense.
Which '+' needs a space?
Please advise,
Eric
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] i.MX6: Add hdmidet command
2013-02-19 23:03 ` Eric Nelson
@ 2013-02-20 0:42 ` Otavio Salvador
2013-02-20 1:16 ` Eric Nelson
0 siblings, 1 reply; 8+ messages in thread
From: Otavio Salvador @ 2013-02-20 0:42 UTC (permalink / raw)
To: u-boot
On Tue, Feb 19, 2013 at 8:03 PM, Eric Nelson
<eric.nelson@boundarydevices.com> wrote:
> Hi Otavio,
>
>
> On 02/19/2013 01:30 PM, Otavio Salvador wrote:
>>
>> On Tue, Feb 19, 2013 at 5:12 PM, Eric Nelson
>> <eric.nelson@boundarydevices.com> wrote:
>>>
>>> Hi Stefano,
>>>
>>> This seems to have gotten lost in the shuffle.
>>>
>>> It's showing as "Changes requested" in Patchwork:
>>>
>>> http://patchwork.ozlabs.org/patch/186280/
>>>
>>> Is there something you'd like changed?
>>>
>>> Please advise,
>>
>>
>> I'd say to use space between the '+' as done in other code.
>>
>
> I must be dense.
>
> Which '+' needs a space?
It seems usually when dealing with offsets we have ' + '. Personally I
think it is clear to read too. But it's not my call so it is up to you
and Stefano.
--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] i.MX6: Add hdmidet command
2013-02-20 0:42 ` Otavio Salvador
@ 2013-02-20 1:16 ` Eric Nelson
2013-02-20 1:19 ` Otavio Salvador
0 siblings, 1 reply; 8+ messages in thread
From: Eric Nelson @ 2013-02-20 1:16 UTC (permalink / raw)
To: u-boot
On 02/19/2013 05:42 PM, Otavio Salvador wrote:
> On Tue, Feb 19, 2013 at 8:03 PM, Eric Nelson
> <eric.nelson@boundarydevices.com> wrote:
>> Hi Otavio,
>>
>>
>> On 02/19/2013 01:30 PM, Otavio Salvador wrote:
>>>
>>> On Tue, Feb 19, 2013 at 5:12 PM, Eric Nelson
>>> <eric.nelson@boundarydevices.com> wrote:
>>>>
>>>> Hi Stefano,
>>>>
>>>> This seems to have gotten lost in the shuffle.
>>>>
>>>> It's showing as "Changes requested" in Patchwork:
>>>>
>>>> http://patchwork.ozlabs.org/patch/186280/
>>>>
>>>> Is there something you'd like changed?
>>>>
>>>> Please advise,
>>>
>>>
>>> I'd say to use space between the '+' as done in other code.
>>>
>>
>> I must be dense.
>>
>> Which '+' needs a space?
>
> It seems usually when dealing with offsets we have ' + '. Personally I
> think it is clear to read too. But it's not my call so it is up to you
> and Stefano.
>
Gotcha.
You mean here:
+{
+ u8 reg = __raw_readb(HDMI_ARB_BASE_ADDR+HDMI_PHY_STAT0);
^
That's the trouble with commenting on the patchwork link...
No context.
Regards,
Eric
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] i.MX6: Add hdmidet command
2013-02-20 1:16 ` Eric Nelson
@ 2013-02-20 1:19 ` Otavio Salvador
2013-02-20 1:21 ` Eric Nelson
0 siblings, 1 reply; 8+ messages in thread
From: Otavio Salvador @ 2013-02-20 1:19 UTC (permalink / raw)
To: u-boot
On Tue, Feb 19, 2013 at 10:16 PM, Eric Nelson
<eric.nelson@boundarydevices.com> wrote:
> On 02/19/2013 05:42 PM, Otavio Salvador wrote:
>>
>> On Tue, Feb 19, 2013 at 8:03 PM, Eric Nelson
>> <eric.nelson@boundarydevices.com> wrote:
>>>
>>> Hi Otavio,
>>>
>>>
>>> On 02/19/2013 01:30 PM, Otavio Salvador wrote:
>>>>
>>>>
>>>> On Tue, Feb 19, 2013 at 5:12 PM, Eric Nelson
>>>> <eric.nelson@boundarydevices.com> wrote:
>>>>>
>>>>>
>>>>> Hi Stefano,
>>>>>
>>>>> This seems to have gotten lost in the shuffle.
>>>>>
>>>>> It's showing as "Changes requested" in Patchwork:
>>>>>
>>>>> http://patchwork.ozlabs.org/patch/186280/
>>>>>
>>>>> Is there something you'd like changed?
>>>>>
>>>>> Please advise,
>>>>
>>>>
>>>>
>>>> I'd say to use space between the '+' as done in other code.
>>>>
>>>
>>> I must be dense.
>>>
>>> Which '+' needs a space?
>>
>>
>> It seems usually when dealing with offsets we have ' + '. Personally I
>> think it is clear to read too. But it's not my call so it is up to you
>> and Stefano.
>>
> Gotcha.
>
> You mean here:
>
> +{
> + u8 reg = __raw_readb(HDMI_ARB_BASE_ADDR+HDMI_PHY_STAT0);
> ^
>
> That's the trouble with commenting on the patchwork link...
Yes; a space between both macros.
--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] i.MX6: Add hdmidet command
2013-02-20 1:19 ` Otavio Salvador
@ 2013-02-20 1:21 ` Eric Nelson
2013-02-20 8:36 ` Stefano Babic
0 siblings, 1 reply; 8+ messages in thread
From: Eric Nelson @ 2013-02-20 1:21 UTC (permalink / raw)
To: u-boot
On 02/19/2013 06:19 PM, Otavio Salvador wrote:
> On Tue, Feb 19, 2013 at 10:16 PM, Eric Nelson
> <eric.nelson@boundarydevices.com> wrote:
>> On 02/19/2013 05:42 PM, Otavio Salvador wrote:
>>>
>>> On Tue, Feb 19, 2013 at 8:03 PM, Eric Nelson
>>> <eric.nelson@boundarydevices.com> wrote:
>>>>
>>>> Hi Otavio,
>>>>
>>>>
>>>> On 02/19/2013 01:30 PM, Otavio Salvador wrote:
>>>>>
>>>>>
>>>>> On Tue, Feb 19, 2013 at 5:12 PM, Eric Nelson
>>>>> <eric.nelson@boundarydevices.com> wrote:
>>>>>>
>>>>>>
>>>>>> Hi Stefano,
>>>>>>
>>>>>> This seems to have gotten lost in the shuffle.
>>>>>>
>>>>>> It's showing as "Changes requested" in Patchwork:
>>>>>>
>>>>>> http://patchwork.ozlabs.org/patch/186280/
>>>>>>
>>>>>> Is there something you'd like changed?
>>>>>>
>>>>>> Please advise,
>>>>>
>>>>>
>>>>>
>>>>> I'd say to use space between the '+' as done in other code.
>>>>>
>>>>
>>>> I must be dense.
>>>>
>>>> Which '+' needs a space?
>>>
>>>
>>> It seems usually when dealing with offsets we have ' + '. Personally I
>>> think it is clear to read too. But it's not my call so it is up to you
>>> and Stefano.
>>>
>> Gotcha.
>>
>> You mean here:
>>
>> +{
>> + u8 reg = __raw_readb(HDMI_ARB_BASE_ADDR+HDMI_PHY_STAT0);
>> ^
>>
>> That's the trouble with commenting on the patchwork link...
>
> Yes; a space between both macros.
>
And a run through checkpatch...
I am dense today.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] i.MX6: Add hdmidet command
2013-02-20 1:21 ` Eric Nelson
@ 2013-02-20 8:36 ` Stefano Babic
0 siblings, 0 replies; 8+ messages in thread
From: Stefano Babic @ 2013-02-20 8:36 UTC (permalink / raw)
To: u-boot
On 20/02/2013 02:21, Eric Nelson wrote:
> On 02/19/2013 06:19 PM, Otavio Salvador wrote:
>> On Tue, Feb 19, 2013 at 10:16 PM, Eric Nelson
>> <eric.nelson@boundarydevices.com> wrote:
>>> On 02/19/2013 05:42 PM, Otavio Salvador wrote:
>>>>
>>>> On Tue, Feb 19, 2013 at 8:03 PM, Eric Nelson
>>>> <eric.nelson@boundarydevices.com> wrote:
>>>>>
>>>>> Hi Otavio,
>>>>>
>>>>>
>>>>> On 02/19/2013 01:30 PM, Otavio Salvador wrote:
>>>>>>
>>>>>>
>>>>>> On Tue, Feb 19, 2013 at 5:12 PM, Eric Nelson
>>>>>> <eric.nelson@boundarydevices.com> wrote:
>>>>>>>
>>>>>>>
>>>>>>> Hi Stefano,
>>>>>>>
>>>>>>> This seems to have gotten lost in the shuffle.
>>>>>>>
>>>>>>> It's showing as "Changes requested" in Patchwork:
>>>>>>>
>>>>>>> http://patchwork.ozlabs.org/patch/186280/
>>>>>>>
>>>>>>> Is there something you'd like changed?
>>>>>>>
>>>>>>> Please advise,
>>>>>>
>>>>>>
>>>>>>
>>>>>> I'd say to use space between the '+' as done in other code.
>>>>>>
>>>>>
>>>>> I must be dense.
>>>>>
>>>>> Which '+' needs a space?
>>>>
>>>>
>>>> It seems usually when dealing with offsets we have ' + '. Personally I
>>>> think it is clear to read too. But it's not my call so it is up to you
>>>> and Stefano.
>>>>
>>> Gotcha.
>>>
>>> You mean here:
>>>
>>> +{
>>> + u8 reg = __raw_readb(HDMI_ARB_BASE_ADDR+HDMI_PHY_STAT0);
>>> ^
>>>
>>> That's the trouble with commenting on the patchwork link...
>>
>> Yes; a space between both macros.
>>
>
> And a run through checkpatch...
>
> I am dense today.
>
Right, sorry for late answer - it is only to fix checkpatch warning,
nothing more. I wll then apply it
Best regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-02-20 8:36 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-19 20:12 [U-Boot] i.MX6: Add hdmidet command Eric Nelson
2013-02-19 20:30 ` Otavio Salvador
2013-02-19 23:03 ` Eric Nelson
2013-02-20 0:42 ` Otavio Salvador
2013-02-20 1:16 ` Eric Nelson
2013-02-20 1:19 ` Otavio Salvador
2013-02-20 1:21 ` Eric Nelson
2013-02-20 8:36 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox