From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add Boundary Devices Nitrogen6X boards
Date: Wed, 20 Feb 2013 09:05:21 -0700 [thread overview]
Message-ID: <5124F441.8060507@boundarydevices.com> (raw)
In-Reply-To: <20130220142041.414A520052F@gemini.denx.de>
Hi Wolfgang,
On 02/20/2013 07:20 AM, Wolfgang Denk wrote:
> Dear Eric Nelson,
>
> In message <1361305248-24598-1-git-send-email-eric.nelson@boundarydevices.com> you wrote:
>
>> +static int detect_hdmi(struct display_info_t const *dev)
>> +{
>> + return __raw_readb(HDMI_ARB_BASE_ADDR+HDMI_PHY_STAT0) & HDMI_PHY_HPD;
> ...
>> + reg = __raw_readb(
>> + HDMI_ARB_BASE_ADDR
>> + +HDMI_PHY_CONF0);
>
> etc. etc.
>
> NAK!! We do not allow device access through base address plus offset
> notation. Please use a proper C Struct to access thes device.
>
This tells me that there's other breakage here. In particular,
this usage follows the lead of drivers/video/ipu_common.c and
the detect code is also present in mx6qsabrelite.c:
http://git.denx.de/u-boot.git/?p=u-boot.git;a=blob;f=board/freescale/mx6qsabrelite/mx6qsabrelite.c;h=f010d0c60d25734d2b81579b6d2806d365a415e6;hb=HEAD#l456
> Also, are you absolutely sure that the __raw_* accessors are the right
> thing to use here? Are you really sure no memory barriers etc. are
> needed here?
>
Good catch. readb() would be more appropriate, though this particular
register is unlikely to produce a different value.
Regards,
Eric
prev parent reply other threads:[~2013-02-20 16:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 20:20 [U-Boot] [PATCH] Add Boundary Devices Nitrogen6X boards Eric Nelson
2013-02-19 20:52 ` Benoît Thébaudeau
2013-02-19 21:53 ` Eric Nelson
2013-02-19 22:31 ` Benoît Thébaudeau
2013-02-19 23:01 ` Eric Nelson
2013-02-20 12:05 ` Benoît Thébaudeau
2013-02-20 13:28 ` Benoît Thébaudeau
2013-02-20 14:08 ` Eric Nelson
2013-02-20 14:20 ` Wolfgang Denk
2013-02-20 16:05 ` Eric Nelson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5124F441.8060507@boundarydevices.com \
--to=eric.nelson@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox