From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 12/20] common: Use new numeric setenv functions
Date: Sun, 24 Feb 2013 15:53:57 -0500 [thread overview]
Message-ID: <512A7DE5.1080709@ti.com> (raw)
In-Reply-To: <CAPnjgZ1t6hfZg2AjKv11VFx-eXBkqBn4gusMxvVBJrpK901SRw@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/24/2013 12:45 PM, Simon Glass wrote:
> Hi Tom,
>
> On Mon, Feb 18, 2013 at 2:08 PM, Tom Rini <trini@ti.com> wrote:
>> On Wed, Dec 26, 2012 at 10:57:05AM -0800, Simon Glass wrote:
>>
>>> Use setenv_ulong(), setenv_hex() and setenv_addr() in common/
>>>
>>> Signed-off-by: Simon Glass <sjg@chromium.org>
>> [snip]
>>> diff --git a/common/cmd_fdos.c b/common/cmd_fdos.c index
>>> fbee861..5a35cc1 100644 --- a/common/cmd_fdos.c +++
>>> b/common/cmd_fdos.c
>> [snip]
>>> @@ -91,8 +90,7 @@ int do_fdosboot(cmd_tbl_t *cmdtp, int flag,
>>> int argc, char * const argv[]) } flush_cache (load_addr,
>>> size);
>>>
>>> - sprintf(buf, "%x", size); - setenv("filesize", buf); +
>>> setenv_hex("filesize", size);
>>
>> Tab and space mixing in the function. I'll fix if git am
>> --whitespace=fix doesn't spot and fix.
>
> I'll change it back to spaces so that it is consistent, even if
> checkpatch is upset. There are now 5 patches changed so I will send
> out the whole series again.
Right, we should always be consistent with the file. From my read of
the series, this was the only one where the file used spaces and the
new insert was tabs, that's what I'm getting at. I guess the others
didn't stick out as obviously?
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJRKn3kAAoJENk4IS6UOR1WV5gP/Ro7jY8wwUV0O4UMYuFidIVG
9SsElNnJoFaoO+qske9MAR6YknpJNb0hu10ZSZWoA+Db1gGeHMwAydG/F8eYJOad
IE26MJVzzSbjmsQx7UJcRKNPfDLKWcZDUMtDC+2YAjT8PvUDRkOqHKqLc/WxcawM
ytsw7o+6lf7GWYABjjEdJkRqd4kd+lq+l6sQoBk0qqQkergjP4+Si3BN3h77ZupV
8hTA7idf3/6ezKjHB3jyMl5kSFrgEPPdhrRNlaYAFriYKpDIwINHEWAYXgQpAtWW
YSA0CQBKZMVE9liMWy3ZWDFslcfk0i72H3m2IP1kNsyRRx0wuekkUlVONc9AQoVe
x3aSnw3LDt0b3SaGhoMLwVKoL6ZI6IKUfAvJNh/tmc/vNbrDmrot2z8mPd4ccKp4
AfrhlpH4KE8eU6zsVpsVWJ85LHaIBu/5SvW73UFLCDZwwnUUIKCj4A903cweCuoG
i8VrY11OliR/yABz+NRRek7Y8pyBMqq40ES4lZJYrcKXwi0k3OwAraCrA73IZeg3
d50ME2WTBQ+tR0cFfp8BZxTVYxrTpHA2diOHL7rdFRfAlii3Wt6Ee9Zbb+ozir6q
TKfxVqJYmHpTYiEt6CuYpq6GD+wQnWbAYkZw5DbmEeq65UUid/UUPcLhDhEinmg6
wbo0UcLD2TLRqc9IS9fX
=lxH4
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-02-24 20:53 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-26 18:56 [U-Boot] [PATCH 0/20] Improvements to memory, hashing functions for sandbox Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 01/20] Tidy up error checking and fix bug in hash command Simon Glass
2013-02-15 23:48 ` Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 02/20] Update print_buffer() to use const Simon Glass
2013-02-15 23:49 ` Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 03/20] sandbox: Improve sandbox serial port keyboard interface Simon Glass
2013-02-15 23:49 ` Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 04/20] sandbox: Add un/map_sysmen() to deal with sandbox's ram_buf Simon Glass
2013-02-15 23:51 ` Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 05/20] sandbox: Change memory commands to use map_physmem Simon Glass
2013-02-15 23:51 ` Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 06/20] Split out the memory tests into separate functions Simon Glass
2013-02-15 23:52 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 07/20] Use common mtest iteration counting Simon Glass
2013-02-15 23:52 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 08/20] Fix mtest indenting Simon Glass
2013-02-15 23:53 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 09/20] Bring mtest putc() into common code Simon Glass
2013-02-15 23:53 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 10/20] Reduce casting in mtest Simon Glass
2013-02-15 23:54 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 11/20] Update set_working_fdt_addr() to use setenv_addr() Simon Glass
2013-02-14 20:00 ` [U-Boot] [PATCH] common/main: move set_working_fdt_addr to enable usage of $fdtaddr Barak Wasserstrom
2013-02-15 23:54 ` [U-Boot] [PATCH 11/20] Update set_working_fdt_addr() to use setenv_addr() Simon Glass
2013-02-25 10:52 ` [U-Boot] [PATCH] common/main: move set_working_fdt_addr to enable usage of $fdtaddr Barak Wasserstrom
2013-02-27 18:48 ` Barak Wasserstrom
2012-12-26 18:57 ` [U-Boot] [PATCH 12/20] common: Use new numeric setenv functions Simon Glass
2013-02-15 23:55 ` Simon Glass
2013-02-18 22:08 ` Tom Rini
2013-02-24 17:45 ` Simon Glass
2013-02-24 20:53 ` Tom Rini [this message]
2013-02-25 3:42 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 13/20] drivers: " Simon Glass
2013-02-15 23:55 ` Simon Glass
2013-02-18 22:37 ` Tom Rini
2012-12-26 18:57 ` [U-Boot] [PATCH 14/20] net: " Simon Glass
2013-02-15 23:56 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 15/20] image: Use crc header file instead of C prototypes Simon Glass
2012-12-26 22:02 ` Marek Vasut
2013-02-15 23:56 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 16/20] Roll crc32 into hash infrastructure Simon Glass
2013-02-15 23:57 ` Simon Glass
2013-02-17 20:53 ` Wolfgang Denk
2013-02-17 21:34 ` Simon Glass
2013-02-17 23:26 ` Tom Rini
2013-02-18 11:35 ` Wolfgang Denk
2013-02-18 16:36 ` Simon Glass
2013-02-18 17:05 ` Tom Rini
2013-02-18 17:06 ` Simon Glass
2013-02-18 22:45 ` Tom Rini
2013-02-19 5:24 ` Simon Glass
2013-02-20 17:04 ` Simon Glass
2013-02-18 23:14 ` Wolfgang Denk
2012-12-26 18:57 ` [U-Boot] [PATCH 17/20] sandbox: config: Enable hash functions and mtest Simon Glass
2013-02-15 23:57 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 18/20] Move CONFIG_SYS_MEMTEST_SCRATCH #ifdef to top of file Simon Glass
2013-02-15 23:58 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 19/20] sandbox: Update mtest to fix crashes Simon Glass
2013-02-15 23:58 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 20/20] sandbox: Allow hash functions to work correctly Simon Glass
2013-02-15 23:58 ` Simon Glass
2013-02-18 22:49 ` [U-Boot] [PATCH 0/20] Improvements to memory, hashing functions for sandbox Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512A7DE5.1080709@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox