[U-Boot] [PATCH v3] Introduced btrfs file-system with btrload command

Tom Rini
2013-02-25T16:29:34Z

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/25/2013 11:08 AM, Adnan Ali wrote:
> On 25/02/13 15:04, Tom Rini wrote:
>> On Mon, Feb 25, 2013 at 12:24:37PM +0000, Adnan Ali wrote:
>>
>>> Introduces btrfs file-system to read file from
>>> volume/sub-volumes with btrload command. This implementation
>>> has read-only support. This btrfs implementation is based on
>>> syslinux btrfs code, commit
>>> 269ebc845ebc8b46ef4b0be7fa0005c7fdb95b8d.
>>>
>>> Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk>
>> A few things: - In general in fs/btrfs/btrfs.c I see some coding
>> style problems (lack of spacing, non-printf's longer than
>> 80-wide). Do these come from syslinux and thus will make any
>> re-syncs easier?
> Most of the ported code is unmodified so its coding style should be
> same as syslinux.

That's what I thought.

>> - It looks like you added support for CONFIG_CMD_FS_GENERIC, if
>> so did you test that?
> This command wasn't enabled in my configs. I haven't added any
> command i.e btrls for this as this feature is not supported yet.

Can you then please? Thanks.

>> - Can you please enable this support code on at least one
>> platform, preferably the one you've tested and developed with?
> Even if do enable support for this, it will also debug 'Unsupported
> filesystem type.'

I don't understand.

> For the rest of changes you proposed i will change them and send as
> v4 patch.

Thanks!

- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRK5FtAAoJENk4IS6UOR1WLbYP/i/c8s10TIoya1UnLiCX87tt
u/DRhip4/HBhyCtZmxCejLM6VrgJ8GBACq7hP6eXY3BE5zRB11rKnaypOdc1EA6h
WG87W+6LDOQEvFPzuyXRpXIGvUwq5gHsa95rM0pq/k5WnUJwl4eRAyuhU0JFilQ8
p83GUbYH3Ss1ZX6sr2O+LNkGrIW/PNw1TVioJYyfUUQvcqVYw8CIBLSusxCkY445
ps2QD3Np4XvYXkGFoHUkb0t+Lp0m87PaHBAuABr+TqUEne+QT3GU1E6xN4jcoasX
2Bd0LQFnIhoU6hiH/EuAsQs8tt48ByEliug0Yvr7iK4Cb5sQen21LjXUagarvArF
RKkg/SThdqwYStfkX5/+z73m2F3lcGGF9IobVuz9HWi2VvXEYM500+pGYcOzjP+3
V+deSp0PReW4lbFRnFgxcArETIumd4+deCQzX9XHUC20iC/Xf2N+s6L5VTGqQf0g
33+QDPaUo1SdCZmKiCpVuBa0hzZsQPRhFOHRUpGbEZRbf45iHl5Ewhm88K6dTiz4
vsr7YJDs4rJcph0q6tKSLVVGioPpa3EqpWZrXGB4JTwc6GHbluAvL7GXrHWxtbtX
AZOxNEegmljq+l+6g+n2sZ+RDlyynU/x9NvKVEM8ucqmMGrcrTKG5fUc536U2sWL
8xEfGHfYMZ9AxbF0DEXY
=FPEv
-----END PGP SIGNATURE-----