public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] ARM: tegra: make CONFIG_CMD_PART common
Date: Wed, 27 Feb 2013 14:03:37 -0700	[thread overview]
Message-ID: <512E74A9.7070700@wwwdotorg.org> (raw)
In-Reply-To: <1361919658-3150-2-git-send-email-swarren@wwwdotorg.org>

On 02/26/2013 04:00 PM, Stephen Warren wrote:
> This is useful on all Tegras, so that boot.scr on all devices can use
> the same commands. Hence, move it to tegra-common.h.

Unfortunately, this breaks Tegra114 builds because no partition types
are enabled, and CONFIG_CMD_PART requires functionality that's only
enabled if some partition types are supported.

There are two possible solutions:

1) Conditionally enable PARTITION_UUIDS and CMD_PART in
tegra-common-post.h only if some partition type is enabled.

2) Also enable DOS and EFI partitions in tegra-common.h, along with all
of FS_EXT4, FS_FAT, CMD_EXT2, CMD_FAT, CMD_FS_GENERIC. For most boards
this won't be any change. For the Colibri T20 and Avionic Design boards,
this ends up enabling a few more options.

(or perhaps enable all of those in tegra-common-post.h only if support
for any block device is enabled)

I prefer option (2). Does anyone object?

  reply	other threads:[~2013-02-27 21:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-26 23:00 [U-Boot] [PATCH 1/2] ARM: tegra: make bounce buffer option Stephen Warren
2013-02-26 23:00 ` [U-Boot] [PATCH 2/2] ARM: tegra: make CONFIG_CMD_PART common Stephen Warren
2013-02-27 21:03   ` Stephen Warren [this message]
2013-02-27 21:43     ` Thierry Reding
2013-02-28 14:58     ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512E74A9.7070700@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox