public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] mtd: cfi_flash: Fix CFI flash driver for 8-bit bus support
Date: Fri, 01 Mar 2013 12:50:38 +0100	[thread overview]
Message-ID: <5130960E.6060206@denx.de> (raw)
In-Reply-To: <02473225-9868-48e6-b67a-898b27e8780d@CO9EHSMHS019.ehs.local>

On 01.03.2013 12:23, Jagannadha Sutradharudu Teki wrote:
> This commit is based on that patch from aaron.williams at caviumnetworks.com
> with same commit along with few code cleanup changes.
> 
> This patch corrects the addresses used when working with Spansion/AMD FLASH chips.
> Addressing for 8 and 16 bits is almost identical except in the 16-bit case the
> LSB of the address is always 0.  The confusion arose because the addresses
> in the datasheet for 16-bit mode are word addresses but this code assumed it was
> byte addresses.
> 
> I have only been able to test this on our Octeon boards which use either an 8-bit
> or 16-bit bus.  I have not tested the case where there's an 8-bit part on a 16-bit
> bus.
> 
> This patch also adds some delays as suggested by Spansion.
> 
> If a part can be both 8 and 16-bits, it forces it to work in 8-bit mode if an
> 8-bit bus is detected.
> 
> Before this fix:
> ---------------
> Bank # 1: CFI conformant flash (8 x 8)  Size: 64 MB in 512 Sectors
>   AMD Standard command set, Manufacturer ID: 0xFF, Device ID: 0xFF
>   Erase timeout: 4096 ms, write timeout: 2 ms
>   Buffer write timeout: 5 ms, buffer size: 1024 bytes
> 
> After this fix:
> --------------
> Bank # 1: CFI conformant flash (8 x 8)  Size: 64 MB in 512 Sectors
>   AMD Standard command set, Manufacturer ID: 0x89, Device ID: 0x7E2301
>   Erase timeout: 4096 ms, write timeout: 2 ms
>   Buffer write timeout: 5 ms, buffer size: 1024 bytes
> 
> Tested on: 256M29EW, 512M29EW flashes.
> 
> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
> Tested-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>

Please preserve the previous commit text and the S-o-b lines for patch
authorship. And add your comments with the additions to this text. And
finally your S-o-b as well of course.

Thanks,
Stefan

  reply	other threads:[~2013-03-01 11:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1362137003-10207-1-git-send-email-jaganna@xilinx.com>
2013-03-01 11:23 ` [U-Boot] [PATCH v3] mtd: cfi_flash: Fix CFI flash driver for 8-bit bus support Jagannadha Sutradharudu Teki
2013-03-01 11:50   ` Stefan Roese [this message]
2013-03-01 11:53     ` Jagan Teki
2013-03-01 11:57       ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5130960E.6060206@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox