From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 1 Mar 2013 09:21:50 -0500 Subject: [U-Boot] [PATCH 0/2] ARM: mmu: Set domain permissions to client access - build warnings! In-Reply-To: <20130301084504.6df4b793@lilith> References: <1357668505-30559-1-git-send-email-r.sricharan@ti.com> <20130228152044.00a8a9fa@lilith> <20130228160546.20a5c643@lilith> <51302E2D.6090103@ti.com> <20130301084504.6df4b793@lilith> Message-ID: <5130B97E.5040308@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 03/01/2013 02:45 AM, Albert ARIBAUD wrote: > Hi Sricharan, > > On Fri, 1 Mar 2013 09:57:25 +0530, Sricharan R > wrote: > >> Hi Albert, >> >> On Thursday 28 February 2013 08:35 PM, Albert ARIBAUD wrote: >>> On Thu, 28 Feb 2013 15:20:44 +0100, Albert ARIBAUD >>> wrote: >>> >>>> (sorry for any duplicate of this mail) >>>> >>>> Hi R Sricharan, >>>> >>>> On Tue, 8 Jan 2013 23:38:22 +0530, R >>>> Sricharan wrote: >>>> >>>>> Currently for ARM based cpu's, mmu pagetable attributes are >>>>> set with manager permissions for all 4GB address space. >>>>> Because of this the 'execute never (XN)' permission is >>>>> never checked on read sensitive regions which results in >>>>> speculative aborts. >>>>> >>>>> This series changes the domain permissions of the full 4GB >>>>> space to client access for OMAP socs. This avoids all the >>>>> speculative aborts that are currently seen on OMAP5 secure >>>>> devices. >>>>> >>>>> Tested on OMAP5 SDP (HS) soc. >>>>> >>>>> This series depends on [1] the patch sent by >>>> Stehle >>>>> >>>>> [1] >>>>> http://www.mail-archive.com/u-boot at lists.denx.de/msg102709.html >>>>> >>>>> >>>>> R Sricharan (2): >>>>> ARM: mmu: Introduce weak dram_bank_setup function ARM: mmu: >>>>> Set domain permissions to client access >>>>> >>>>> arch/arm/cpu/armv7/cache_v7.c | 3 ++ >>>>> arch/arm/cpu/armv7/omap-common/hwinit-common.c | 35 >>>>> ++++++++++++++++++++++++ arch/arm/include/asm/cache.h >>>>> | 1 + arch/arm/include/asm/system.h | >>>>> 14 ++++++++++ arch/arm/lib/cache-cp15.c >>>>> | 13 ++++++++- 5 files changed, 65 insertions(+), 1 >>>>> deletion(-) >>>>> >>>> Series applied to u-boot-arm/master, thanks! >>> Correction: I'd wrongly inferred from the testing done on OMAP5 >>> that the series would build fine. However it appears that for >>> targets omap4_sdp4430, omap4_panda and omap5_evm, patch 2/2 has >>> warnings: >>> >>> hwinit-common.c: In function 'dram_bank_mmu_setup': >>> hwinit-common.c:279:3: warning: implicit declaration of >>> function 'set_section_dcache' >>> [-Wimplicit-function-declaration] >>> >>> Luckily, I had not committed to the git repo yet. >>> >>> R Sicharan, can you please check and fix this warning? >>> >>> Amicalement, >> Oh, thats because as i mentioned above, it depends on the below >> patch from vincent . >> >> http://www.mail-archive.com/u-boot at lists.denx.de/msg102709.html >> >> I did not repost it though. I will do it now for clarity. > > Ok -- Vincent's patch was not in my Patchwork TODO and I had read > patches 1/2 and 2/2 in Patchwork, but I had not read the cover > letter thoroughly enough so I had missed the dependency. > > (Cc:ing Vincent and Tom) > > Vincent's patch series is delegated to Tom and marked "superseded" > in Patchwork but I don't see any later, superseding, series. What > can/should I make of it? It's possible I mis-read things and it shouldn't be superseded. Can you list all of the patches that Albert should apply please? Thanks! - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRMLl9AAoJENk4IS6UOR1WPX4P+wRRwsSgPm5edbbBN/TkBi6a x1LIMEKYC2QN73ea8czz4oeOR76MXidQUdYRmimJ2qzYRaEq9Y9ulFjIs0zc/6Gu ydnO4eeb8keU27ItlmKubnEOwsev/wtZNIQhvwJJNvuSiG9rBvKAGDh9L8UQrq3t cwhqWpNhL4isoYG/rB2BDHKrwB62DboOzmaNHACpVaCZNg606QH+eHnget1CWBCD p2O88TSkOVoQHVAj76mdgm8+9WE/mlqn5h4RUU81U3DHiAuTDg0N+J1IJPd3zjhP 86zvj1q4i3JuZySg+IdxouiPTqnw88ZYJ2XHtQvAeDGr5Q680Gb1k18vMIRGlNtv AVx9ipQHaOFXSbTQzlmTNT4EutseaGVa5Ioj3vUkRozBONIfuDmEZAnE+YXFfgQV OQZzidbWLOSFbfDPSi6XMUgtXVEtUPP6eGPV0sv5HUvfYr+3zUMtFwdGqe47X1lC z5V1xpug2mOvU0+6l1nO1egxdRM1JlHroV33oRBXMFoUZUowpobGWeJubjw7WB86 39qoR4xwnyPup3+HHlKVBXmRg6j7jayOUdU0o69kJYO7M0QB/CjADePpSDTrcb9n lkk5KSYVQRzbOar7n9J6jiYoL5WFdj7uSCLpfQ5u/b26r/U2I/YGWPj/w6oGR9+v +3tp/XeRDuXUQkplQEd7 =jW2y -----END PGP SIGNATURE-----