From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Date: Sun, 03 Mar 2013 12:43:34 +0100
Subject: [U-Boot] [PATCH v3 08/10] NET: mvgbe: add support for Dove
In-Reply-To: <F766E4F80769BD478052FB6533FA745D25F41F4241@SC-VEXCH4.marvell.com>
References: <1354609923-27320-1-git-send-email-sebastian.hesselbarth@gmail.com>
	<1358364328-14904-1-git-send-email-sebastian.hesselbarth@gmail.com>
	<1358364328-14904-9-git-send-email-sebastian.hesselbarth@gmail.com>
	<F766E4F80769BD478052FB6533FA745D25F41F4241@SC-VEXCH4.marvell.com>
Message-ID: <51333766.70901@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 02/11/2013 04:39 AM, Prafulla Wadaskar wrote:
>> -----Original Message-----
>> From: Sebastian Hesselbarth [mailto:sebastian.hesselbarth at gmail.com]
>> Sent: 17 January 2013 00:55
>> To: Sebastian Hesselbarth
>> Cc: u-boot at lists.denx.de; Rabeeh Khoury; Albert Aribaud; Prafulla
>> Wadaskar; Andy Fleming; Joe Hershberger; Daniel Stodden; Luka Perkov
>> Subject: [PATCH v3 08/10] NET: mvgbe: add support for Dove
>>
>> Marvell Dove also uses mvgbe as ethernet driver, therefore add support
>> for Dove to reuse the current driver.
>>
>> Signed-off-by: Sebastian Hesselbarth<sebastian.hesselbarth@gmail.com>
>> ---
>> Cc: u-boot at lists.denx.de
>> Cc: Sebastian Hesselbarth<sebastian.hesselbarth@gmail.com>
>> Cc: Rabeeh Khoury<rabeeh@solid-run.com>
>> Cc: Albert Aribaud<albert.u.boot@aribaud.net>
>> Cc: Prafulla Wadaskar<prafulla@marvell.com>
>> Cc: Andy Fleming<afleming@gmail.com>
>> Cc: Joe Hershberger<joe.hershberger@gmail.com>
>> Cc: Daniel Stodden<daniel.stodden@gmail.com>
>> Cc: Luka Perkov<luka@openwrt.org>
>> ---
>>   drivers/net/mvgbe.c |    2 ++
>>   drivers/net/mvgbe.h |    7 +++++++
>>   2 files changed, 9 insertions(+)
>>
>> diff --git a/drivers/net/mvgbe.c b/drivers/net/mvgbe.c
>> index 192c989..590ea0b 100644
>> --- a/drivers/net/mvgbe.c
>> +++ b/drivers/net/mvgbe.c
>> @@ -43,6 +43,8 @@
>>   #include<asm/arch/kirkwood.h>
>>   #elif defined(CONFIG_ORION5X)
>>   #include<asm/arch/orion5x.h>
>> +#elif defined(CONFIG_DOVE)
>> +#include<asm/arch/dove.h>
>>   #endif
>>
>>   #include "mvgbe.h"
>> diff --git a/drivers/net/mvgbe.h b/drivers/net/mvgbe.h
>> index d8a5429..7f5d98f 100644
>> --- a/drivers/net/mvgbe.h
>> +++ b/drivers/net/mvgbe.h
>> @@ -308,10 +308,17 @@
>>   #define EBAR_TARGET_GUNIT			0x00000007
>>
>>   /* Window attrib */
>> +#if defined(CONFIG_DOVE)
>> +#define EBAR_DRAM_CS0				0x00000000
>> +#define EBAR_DRAM_CS1				0x00000000
>> +#define EBAR_DRAM_CS2				0x00000000
>> +#define EBAR_DRAM_CS3				0x00000000
>
> What does this means?
> May you please explain?

These are ORed with other BAR values within mvgbe and control access
of mvgbe bus master to sdram. In contrast to Kirkwood, Dove has only
one sdram target interface with attribute 0x0 while Kirkwood has four
different target IDs each for one sdram bank.

Sebastian