From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 2/5] cmd_nand.c: Fix CONFIG_CMD_NAND_YAFFS
Date: Mon, 4 Mar 2013 20:27:40 -0500 [thread overview]
Message-ID: <51354A0C.3040901@ti.com> (raw)
In-Reply-To: <1362445974.16575.11@snotra>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 03/04/2013 08:12 PM, Scott Wood wrote:
> On 03/04/2013 04:17:10 PM, Tom Rini wrote:
>> The flag changed from WITH_INLINE_OOB to WITH_YAFFS_OOB by
>> accident in 418396e.
>>
>> Signed-off-by: Tom Rini <trini@ti.com> --- Changes in v4: - Add
>> patch to fix CONFIG_CMD_NAND_YAFFS
>>
>> Changes in v3: None Changes in v2: None
>>
>> common/cmd_nand.c | 2 +- 1 file changed, 1 insertion(+), 1
>> deletion(-)
>>
>> diff --git a/common/cmd_nand.c b/common/cmd_nand.c index
>> 76f4d3f..d9010d2 100644 --- a/common/cmd_nand.c +++
>> b/common/cmd_nand.c @@ -673,7 +673,7 @@ static int
>> do_nand(cmd_tbl_t *cmdtp, int flag, int argc, char * const
>> argv[]) } ret = nand_write_skip_bad(nand, off, &rwsize, NULL,
>> maxsize, (u_char *)addr, -
>> WITH_INLINE_OOB); + WITH_YAFFS_OOB);
>> #endif
>
> Oops. Probably a leftover from an attempt to share code between
> yaffs and raw accesses.
>
> BTW, it looks like there is no board that selects
> CONFIG_CMD_NAND_YAFFS, so it doesn't get compile tested... ...and
> smdk6400 defines CONFIG_SYS_NAND_YAFFS_WRITE, which nothing ever
> tests. :-P
Indeed. We lack some real users of YAFFS in U-Boot right now, and I
don't wish to open a can of worms on why that might be.
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJRNUoMAAoJENk4IS6UOR1WH0IP/j0MPShdroqdmLXZKkG5wFOv
yhg2hiXYGQU9eruBC0poGbPNQxaUA68rWwBe770f+S++ovpNQ3jORS/1I6OdpUqt
c0EMcnY2GHCVP6Ct5lrqccif9SC0q0vueMqd2agErnkPZzfkKFFsyPkfAIoXIWcD
vl8gA9yGpRP0GpIbN25Ow0WmV/cgyQzorwuwZPdQQ52jFKCH+g12YvdTdBG1nB70
ZZS79pKMy49YdSElTROb2WbfBU2j8kNK4FlOXoR+5wea6t6ejDr40WTFlqY+IU7E
AYegnYNQcYcAq/yENKcTE6py7j94kDclVp5L+1aUpyZmsFNOP44BcGDIkubQAWR5
Cp9FRtRC2PEBOUTZv/3GDbn9OogIxqlKOwSbAj4A977bBT965IVZZoNS68hAOQph
vTf1umSQQXqUjybPyhcCH3hDeULXjKkjj+Vi5pgwoBM28IRmbhBm68aSLX1FZL2x
waWVsGa1J8bd96ZWZ6ML5vB9dUpdywW/tFOvPMkNyj43ugHEmaJ8EXdTB2H+1B+f
b0tkCaMwU+Qd0kFlfIyEseR8QbG5K6ngZDCUtcw7LKQy+vC7YfaH6kx8sXaSdg4J
QKNCqoQ+6uk6EfYJkVtK4NJTojRmu+jVTjv2Yne2if1uhYs7f04S1NZlqCmAUNAl
QUU7sJ97JECLYDFITqBC
=MFnf
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-03-05 1:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 22:17 [U-Boot] [PATCH v4 0/5] Add NAND support to DFU, enable for am335x_evm Tom Rini
2013-03-04 22:17 ` [U-Boot] [PATCH v4 1/5] nand: Extend nand_(read|write)_skip_bad with *actual and limit parameters Tom Rini
2013-03-04 22:17 ` [U-Boot] [PATCH v4 2/5] cmd_nand.c: Fix CONFIG_CMD_NAND_YAFFS Tom Rini
2013-03-05 1:12 ` Scott Wood
2013-03-05 1:27 ` Tom Rini [this message]
2013-03-05 1:35 ` Scott Wood
2013-03-04 22:17 ` [U-Boot] [PATCH v4 3/5] dfu: NAND specific routines for DFU operation Tom Rini
2013-03-04 22:17 ` [U-Boot] [PATCH v4 4/5] am335x_evm: Add CONFIG_CMD_MTDPARTS and relevant defaults Tom Rini
2013-03-04 22:17 ` [U-Boot] [PATCH v4 5/5] am335x_evm: Enable DFU for NAND and MMC, provide example alt_info for both Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51354A0C.3040901@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox