From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bo Shen <voice.shen@atmel.com>
Date: Tue, 05 Mar 2013 10:23:22 +0800
Subject: [U-Boot] [PATCH 4/4] ARM: atmel: add sama5d3xek support
In-Reply-To: <20130305022015.GC16106@bill-the-cat>
References: <1362034848-6371-1-git-send-email-voice.shen@atmel.com>
	<1362034848-6371-5-git-send-email-voice.shen@atmel.com>
	<20130304151459.GA25797@bill-the-cat> <5135528D.7050800@atmel.com>
	<20130305022015.GC16106@bill-the-cat>
Message-ID: <5135571A.5060700@atmel.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Tom,
   Thanks.

On 3/5/2013 10:20, Tom Rini wrote:
> On Tue, Mar 05, 2013 at 10:03:57AM +0800, Bo Shen wrote:
>> Hi Tom,
>>
>> On 3/4/2013 23:14, Tom Rini wrote:
>>> On Thu, Feb 28, 2013 at 03:00:47PM +0800, Bo Shen wrote:
> [snip]
>>>> @@ -0,0 +1,268 @@
>>>> +/*
>>>> + * Configuation settings for the SAMA5D3xEK board.
>>> [snip]
>>>> +#undef CONFIG_USE_IRQ			/* we don't need IRQ/FIQ stuff	*/
>>>> +
>>>> +#undef CONFIG_CMDLINE_TAG		/* enable passing of ATAGs	*/
>>>> +#undef CONFIG_SETUP_MEMORY_TAGS
>>>> +#undef CONFIG_INITRD_TAG
>>>
>>> Just leave these, and the other #undef's out.
>>
>> You mean I need not to #undef these, because these are not defined,
>> am I right?
>
> Correct.

OK, I will remove it next version.

>>
>>>> +/*
>>>> + * Command line configuration.
>>>> + */
>>>> +#include <config_cmd_default.h>
>>>> +#undef CONFIG_CMD_FPGA
>>>> +#undef CONFIG_CMD_IMI
>>>> +#undef CONFIG_CMD_IMLS
>>>> +#undef CONFIG_CMD_AUTOSCRIPT
>>>> +#undef CONFIG_CMD_LOADS
>>>
>>> These are fine to leave in 'tho.
>>
>> These are no useful for us.
>> I will consider remove unneeded #undef
>
> Right.

Ditto.

>>> And please check things with checkpatch.pl, I
>>> thought I saw a '#define<tab>FOO' in there.  Thanks!
>>
>> I have checked this patch with checkpatch.pl, and get no errors and
>> no warnings.
>
> OK, thanks.

Best Regards,
Bo Shen