public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MAKEALL: allow regex matches for -s option
Date: Tue, 05 Mar 2013 16:39:52 -0700	[thread overview]
Message-ID: <51368248.4090605@wwwdotorg.org> (raw)
In-Reply-To: <51367B02.1020104@ti.com>

On 03/05/2013 04:08 PM, Tom Rini wrote:
> On 03/05/2013 04:43 PM, Stephen Warren wrote:
>> On 03/05/2013 02:37 PM, Wolfgang Denk wrote:
>>> Dear Stephen Warren,
>>>
>>> In message
>>> <1362518101-5742-1-git-send-email-swarren@wwwdotorg.org> you
>>> wrote:
>>>> From: Stephen Warren <swarren@nvidia.com>
>>>>
>>>> This allows:
>>>>
>>>> MAKEALL -s tegra*
>>>>
>>>> to replace:
>>>>
>>>> MAKEALL -s tegra20 -s tegra30 -s tegra114
>>>>
>>>> Signed-off-by: Stephen Warren <swarren@nvidia.com> --- MAKEALL
>>>> |    4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/MAKEALL b/MAKEALL index 5b06c54..0ed6986 100755 
>>>> --- a/MAKEALL +++ b/MAKEALL @@ -101,9 +101,9 @@ while true ;
>>>> do -s|--soc) # echo "Option SoC: argument \`$2'" if [ "$opt_s"
>>>> ] ; then -			opt_s="${opt_s%)} || \$6 == \"$2\")" +
>>>> opt_s="${opt_s%)} || \$6 == \"$2\" || \$6 ~ /$2/)"
>>>
>>> Is this actually correct?  I see 2 x closing parens here, with
>>> no matching open parens?
> 
>> Yes, it's confusing, but I believe correct (although I didn't
>> actually test multiple -s options).
> 
> Can you try MAKEALL -s tegra* -s omap* and see what happens?

Looks like it works fine:

--------------------- SUMMARY ----------------------------
Boards compiled: 49
Boards with warnings but no errors: 49 ( omap2420h4 nhk8815
nhk8815_onenand omap5912osk omap730p2 omap730p2_cs0boot
omap730p2_cs3boot eco5pk cm_t35 omap3_overo omap3_pandora dig297
igep0020 igep0020_nand igep0030 igep0030_nand igep0032 am3517_evm
mt_ventoux omap3_zoom1 omap3_zoom2 omap3_logic omap3_mvblx am3517_crane
omap3_beagle omap3_evm omap3_evm_quick_mmc omap3_evm_quick_nand
omap3_sdp3430 devkit8000 mcx tricorder twister nokia_rx51 omap4_panda
omap4_sdp4430 omap5_evm harmony seaboard ventana whistler cardhu dalmore
colibri_t20_iris plutux medcom-wide tec paz00 trimslice )
----------------------------------------------------------

the warning is nothing to do with this patch; my toolchain says the
following every time:)

/path/to/arm-cortex_a9-linux-gnueabi-ld: warning: creating a DT_TEXTREL
in object.

      reply	other threads:[~2013-03-05 23:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-05 21:15 [U-Boot] [PATCH] MAKEALL: allow regex matches for -s option Stephen Warren
2013-03-05 21:37 ` Wolfgang Denk
2013-03-05 21:43   ` Stephen Warren
2013-03-05 23:08     ` Tom Rini
2013-03-05 23:39       ` Stephen Warren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51368248.4090605@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox