From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 05 Mar 2013 16:39:52 -0700 Subject: [U-Boot] [PATCH] MAKEALL: allow regex matches for -s option In-Reply-To: <51367B02.1020104@ti.com> References: <1362518101-5742-1-git-send-email-swarren@wwwdotorg.org> <20130305213737.B503D20003F@gemini.denx.de> <513666E6.6010204@wwwdotorg.org> <51367B02.1020104@ti.com> Message-ID: <51368248.4090605@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 03/05/2013 04:08 PM, Tom Rini wrote: > On 03/05/2013 04:43 PM, Stephen Warren wrote: >> On 03/05/2013 02:37 PM, Wolfgang Denk wrote: >>> Dear Stephen Warren, >>> >>> In message >>> <1362518101-5742-1-git-send-email-swarren@wwwdotorg.org> you >>> wrote: >>>> From: Stephen Warren >>>> >>>> This allows: >>>> >>>> MAKEALL -s tegra* >>>> >>>> to replace: >>>> >>>> MAKEALL -s tegra20 -s tegra30 -s tegra114 >>>> >>>> Signed-off-by: Stephen Warren --- MAKEALL >>>> | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/MAKEALL b/MAKEALL index 5b06c54..0ed6986 100755 >>>> --- a/MAKEALL +++ b/MAKEALL @@ -101,9 +101,9 @@ while true ; >>>> do -s|--soc) # echo "Option SoC: argument \`$2'" if [ "$opt_s" >>>> ] ; then - opt_s="${opt_s%)} || \$6 == \"$2\")" + >>>> opt_s="${opt_s%)} || \$6 == \"$2\" || \$6 ~ /$2/)" >>> >>> Is this actually correct? I see 2 x closing parens here, with >>> no matching open parens? > >> Yes, it's confusing, but I believe correct (although I didn't >> actually test multiple -s options). > > Can you try MAKEALL -s tegra* -s omap* and see what happens? Looks like it works fine: --------------------- SUMMARY ---------------------------- Boards compiled: 49 Boards with warnings but no errors: 49 ( omap2420h4 nhk8815 nhk8815_onenand omap5912osk omap730p2 omap730p2_cs0boot omap730p2_cs3boot eco5pk cm_t35 omap3_overo omap3_pandora dig297 igep0020 igep0020_nand igep0030 igep0030_nand igep0032 am3517_evm mt_ventoux omap3_zoom1 omap3_zoom2 omap3_logic omap3_mvblx am3517_crane omap3_beagle omap3_evm omap3_evm_quick_mmc omap3_evm_quick_nand omap3_sdp3430 devkit8000 mcx tricorder twister nokia_rx51 omap4_panda omap4_sdp4430 omap5_evm harmony seaboard ventana whistler cardhu dalmore colibri_t20_iris plutux medcom-wide tec paz00 trimslice ) ---------------------------------------------------------- the warning is nothing to do with this patch; my toolchain says the following every time:) /path/to/arm-cortex_a9-linux-gnueabi-ld: warning: creating a DT_TEXTREL in object.