[U-Boot] [PATCH V2] Add Boundary Devices Nitrogen6X boards

Wolfgang Denk
2013-03-10T08:02:09Z

Dear Troy,

In message <513BD8AA.4060000@boundarydevices.com> you wrote:
> On 3/9/2013 5:04 PM, Eric Nelson wrote:
> > diff --git a/board/boundary/nitrogen6x/nitrogen6x.c b/board/boundary/nitrogen6x/nitrogen6x.c
> > new file mode 100644
> > index 0000000..147bd91
> > --- /dev/null
> > +++ b/board/boundary/nitrogen6x/nitrogen6x.c
> > @@ -0,0 +1,895 @@
> > +int dram_init(void)
> > +{
> > + gd->ram_size = get_ram_size((void *)PHYS_SDRAM, PHYS_SDRAM_SIZE);
>
> This will hang a solo if
>
> PHYS_SDRAM_SIZE is bigger than actual memory size
>
> which makes calling get_ram_size pretty useless.

If this is the case, then there is a bug in the code resp. the code is
incomplete. get_ram_size() has always been used to detect smaller
than the maximum possible (configured) RAM sizes; actually this is
it's main purpose.

If this is not really working, then it needs to be fixed.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Monday is an awful way to spend one seventh of your life.