From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] Tegra114: Dalmore: Add SDIO3 pad config to pinctrl_config table
Date: Tue, 12 Mar 2013 11:52:46 -0600 [thread overview]
Message-ID: <513F6B6E.7060208@wwwdotorg.org> (raw)
In-Reply-To: <1363105031-30296-3-git-send-email-twarren@nvidia.com>
On 03/12/2013 10:17 AM, Tom Warren wrote:
> SDIO1 (the SD-card slot on Dalmore) needs to have its pads setup
> before the MMC driver is added.
> diff --git a/board/nvidia/dalmore/dalmore.c b/board/nvidia/dalmore/dalmore.c
> + /* Initialize any non-default pad configs (APB_MISC_GP regs) */
> + padgrp_config_table(dalmore_padctrl, ARRAY_SIZE(dalmore_padctrl));
Given that you're only using this table for the very first time here ...
> diff --git a/board/nvidia/dalmore/pinmux-config-dalmore.h b/board/nvidia/dalmore/pinmux-config-dalmore.h
> static struct padctrl_config dalmore_padctrl[] = {
> /* (_padgrp, _slwf, _slwr, _drvup, _drvdn, _lpmd, _schmt, _hsm) */
> + DEFAULT_PADCFG(SDIO3, SDIOCFG_DRVUP_SLWF, SDIOCFG_DRVDN_SLWR, \
> + SDIOCFG_DRVUP, SDIOCFG_DRVDN, NONE, DISABLE, ENABLE),
> };
... and it was empty before now, I'd be inclined to remove the *dalmore*
files from the Tegra114 pinmux series that implemented
padgrp_config_table(), and just do all the Dalmore-specific stuff in
this patch.
But it's not a big deal.
next prev parent reply other threads:[~2013-03-12 17:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 16:17 [U-Boot] [PATCH 0/4] Tegra114: MMC: Add MMC driver for T114/Dalmore Tom Warren
2013-03-12 16:17 ` [U-Boot] [PATCH 1/4] Tegra114: fdt: Add SDMMC (sdhci) nodes for T114 boards (Dalmore for now) Tom Warren
2013-03-12 16:17 ` [U-Boot] [PATCH 2/4] Tegra114: Dalmore: Add SDIO3 pad config to pinctrl_config table Tom Warren
2013-03-12 17:52 ` Stephen Warren [this message]
2013-03-12 17:59 ` Tom Warren
2013-03-12 16:17 ` [U-Boot] [PATCH 3/4] Tegra114: MMC: Add SD bus power-rail init routine Tom Warren
2013-03-12 17:54 ` Stephen Warren
2013-03-12 18:05 ` Tom Warren
2013-03-12 18:13 ` Stephen Warren
2013-03-12 16:17 ` [U-Boot] [PATCH 4/4] Tegra114: MMC: Enable DT MMC driver support for Tegra114 Dalmore boards Tom Warren
2013-03-12 17:56 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513F6B6E.7060208@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox