From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] Tegra114: MMC: Add SD bus power-rail init routine
Date: Tue, 12 Mar 2013 11:54:44 -0600 [thread overview]
Message-ID: <513F6BE4.3000109@wwwdotorg.org> (raw)
In-Reply-To: <1363105031-30296-4-git-send-email-twarren@nvidia.com>
On 03/12/2013 10:17 AM, Tom Warren wrote:
> T114 requires SD bus power-rail bringup for the SDIO card on SDMMC3.
> diff --git a/board/nvidia/dalmore/dalmore.c b/board/nvidia/dalmore/dalmore.c
> +#if defined(CONFIG_TEGRA_MMC)
It always is for Dalmore, right?
> +void board_sdmmc_voltage_init(void)
> + /* TPS65913: LDO9_VOLTAGE = 3.3V */
> + data_buffer[0] = 0x31;
> + reg = 0x61;
> +
> + for (i = 0; i < MAX_I2C_RETRY; ++i) {
> + ret = i2c_write(PMU_I2C_ADDRESS, reg, 1, data_buffer, 1);
> + if (ret) {
> + udelay(100);
> + printf("%s: PMU i2c_write %02X<-%02X returned %d\n",
> + __func__, reg, data_buffer[0], ret);
> + }
> + }
Is there actually a need to retry these transactions; is there any
evidence they're expected to fail? Hopefully the HW isn't flaky like that.
AFAIK, the kernel driver for the PMIC doesn't retry these if they fail.
Hopefully it doesn't need to start doing so.
next prev parent reply other threads:[~2013-03-12 17:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 16:17 [U-Boot] [PATCH 0/4] Tegra114: MMC: Add MMC driver for T114/Dalmore Tom Warren
2013-03-12 16:17 ` [U-Boot] [PATCH 1/4] Tegra114: fdt: Add SDMMC (sdhci) nodes for T114 boards (Dalmore for now) Tom Warren
2013-03-12 16:17 ` [U-Boot] [PATCH 2/4] Tegra114: Dalmore: Add SDIO3 pad config to pinctrl_config table Tom Warren
2013-03-12 17:52 ` Stephen Warren
2013-03-12 17:59 ` Tom Warren
2013-03-12 16:17 ` [U-Boot] [PATCH 3/4] Tegra114: MMC: Add SD bus power-rail init routine Tom Warren
2013-03-12 17:54 ` Stephen Warren [this message]
2013-03-12 18:05 ` Tom Warren
2013-03-12 18:13 ` Stephen Warren
2013-03-12 16:17 ` [U-Boot] [PATCH 4/4] Tegra114: MMC: Enable DT MMC driver support for Tegra114 Dalmore boards Tom Warren
2013-03-12 17:56 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513F6BE4.3000109@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox