public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] Tegra114: MMC: Enable DT MMC driver support for Tegra114 Dalmore boards
Date: Tue, 12 Mar 2013 11:56:27 -0600	[thread overview]
Message-ID: <513F6C4B.5020404@wwwdotorg.org> (raw)
In-Reply-To: <1363105031-30296-5-git-send-email-twarren@nvidia.com>

On 03/12/2013 10:17 AM, Tom Warren wrote:
> Tested on my Dalmore E1611 board, eMMC and SD-Card work fine, can load
> a kernel off of an SD card OK, card detect works, and the env is now
> stored in eMMC (end of the 2nd 'boot' sector, same as Tegra20/30).

> diff --git a/include/configs/dalmore.h b/include/configs/dalmore.h

> +/* Environment in eMMC, at the end of 2nd "boot sector" */
> +#define CONFIG_ENV_IS_IN_MMC
> +#define CONFIG_ENV_OFFSET		((512 * 1024) - CONFIG_ENV_SIZE)
> +#define CONFIG_SYS_MMC_ENV_DEV		0
> +#define CONFIG_SYS_MMC_ENV_PART		2

I believe that Dalmore's eMMC "boot" sectors are 4MiB in size, so that'd
want to be (4096 - 512) * 1024) - CONFIG_ENV_SIZE. At least, that's what
"mmcinfo" told me when running our downstream U-Boot on my Dalmore.

Aside from the comments I've made, the series,
Reviewed-by: Stephen Warren <swarren@nvidia.com>

      reply	other threads:[~2013-03-12 17:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-12 16:17 [U-Boot] [PATCH 0/4] Tegra114: MMC: Add MMC driver for T114/Dalmore Tom Warren
2013-03-12 16:17 ` [U-Boot] [PATCH 1/4] Tegra114: fdt: Add SDMMC (sdhci) nodes for T114 boards (Dalmore for now) Tom Warren
2013-03-12 16:17 ` [U-Boot] [PATCH 2/4] Tegra114: Dalmore: Add SDIO3 pad config to pinctrl_config table Tom Warren
2013-03-12 17:52   ` Stephen Warren
2013-03-12 17:59     ` Tom Warren
2013-03-12 16:17 ` [U-Boot] [PATCH 3/4] Tegra114: MMC: Add SD bus power-rail init routine Tom Warren
2013-03-12 17:54   ` Stephen Warren
2013-03-12 18:05     ` Tom Warren
2013-03-12 18:13       ` Stephen Warren
2013-03-12 16:17 ` [U-Boot] [PATCH 4/4] Tegra114: MMC: Enable DT MMC driver support for Tegra114 Dalmore boards Tom Warren
2013-03-12 17:56   ` Stephen Warren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513F6C4B.5020404@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox