From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Tegra114: pinmux: Fix bad CAM_MCLK func 3 table entry
Date: Wed, 13 Mar 2013 16:34:42 -0600 [thread overview]
Message-ID: <5140FF02.4090509@wwwdotorg.org> (raw)
In-Reply-To: <1363212640-16811-1-git-send-email-twarren@nvidia.com>
On 03/13/2013 04:10 PM, Tom Warren wrote:
> This caused CAM_MCLK's pinmux reg to be locked out, since the
> table parsing code couldn't find a matching entry for VI_ALT3
> and wrote garbage to the register.
> diff --git a/arch/arm/cpu/tegra114-common/pinmux.c b/arch/arm/cpu/tegra114-common/pinmux.c
> @@ -239,7 +239,7 @@ const struct tegra_pingroup_desc tegra_soc_pingroups[PINGRP_COUNT] = {
> - PINI(CAM_MCLK, CAM, VI, VI_ALT1, VI_ALT2, RSVD4),
> + PINI(CAM_MCLK, CAM, VI, VI_ALT1, VI_ALT3, RSVD4),
This doesn't seem right; the "alt" settings should be assigned in order
non-alt, alt1, alt2, alt3.
You say, "the table parsing code couldn't find a matching entry for
VI_ALT3". What was looking for that entry?
Also, shouldn't the pinmux driver be fixed not to write garbage to a
register, but instead return an error, if it can't find the table entry
it's looking for?
next prev parent reply other threads:[~2013-03-13 22:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 22:10 [U-Boot] [PATCH] Tegra114: pinmux: Fix bad CAM_MCLK func 3 table entry Tom Warren
2013-03-13 22:34 ` Stephen Warren [this message]
2013-03-13 22:55 ` Tom Warren
2013-03-13 23:26 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5140FF02.4090509@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox