public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Tegra114: Dalmore: Always use DEFAULT instead of DISABLE for lock bits
Date: Wed, 13 Mar 2013 17:31:21 -0600	[thread overview]
Message-ID: <51410C49.2010709@wwwdotorg.org> (raw)
In-Reply-To: <1363214781-5726-1-git-send-email-twarren@nvidia.com>

On 03/13/2013 04:46 PM, Tom Warren wrote:
> The pinmux code issues a warning if the aller attempts to disable the
> lock bit in a pinmux register, since this is impossible (once it's
> locked, the only way to unlock it is to reset the device/pmt controller).
> 
> The I2C/DDC/CEC/USB macros expect a lock setting to be passed in,
> and the previous setting of DISABLE caused the pinmux table parsing
> code to issue the warning. Changing the lock bits in these table
> entries to DEFAULT (i.e. don't touch it) fixes this.

Sounds reasonable,
Reviewed-by: Stephen Warren <swarren@nvidia.com>

      parent reply	other threads:[~2013-03-13 23:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-13 22:46 [U-Boot] [PATCH] Tegra114: Dalmore: Always use DEFAULT instead of DISABLE for lock bits Tom Warren
2013-03-13 22:55 ` Tom Warren
2013-03-13 23:31 ` Stephen Warren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51410C49.2010709@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox