From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Thu, 14 Mar 2013 08:42:05 +0100 Subject: [U-Boot] [PATCH v2 2/2] nitrogen: Use unsigned long to specify the total RAM size In-Reply-To: <1363215553-27684-2-git-send-email-festevam@gmail.com> References: <1363215553-27684-1-git-send-email-festevam@gmail.com> <1363215553-27684-2-git-send-email-festevam@gmail.com> Message-ID: <51417F4D.8010901@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 13/03/2013 23:59, Fabio Estevam wrote: > From: Fabio Estevam > > > When building for the nitrogen boards with 2GB the following warning happens: > > nitrogen6x.c:89:38: warning: integer overflow in expression [-Woverflow] > > 2GB can not fit in 32-bits, so use ulong instead. > > Reported-by: Albert Aribaud > Signed-off-by: Fabio Estevam > --- Hi Fabio, > Changes since v1: > - No changes > board/boundary/nitrogen6x/nitrogen6x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/boundary/nitrogen6x/nitrogen6x.c b/board/boundary/nitrogen6x/nitrogen6x.c > index 0dbb6d2..e5634d8 100644 > --- a/board/boundary/nitrogen6x/nitrogen6x.c > +++ b/board/boundary/nitrogen6x/nitrogen6x.c > @@ -86,7 +86,7 @@ DECLARE_GLOBAL_DATA_PTR; > > int dram_init(void) > { > - gd->ram_size = CONFIG_DDR_MB * 1024 * 1024; > + gd->ram_size = (ulong)(CONFIG_DDR_MB * 1024 * 1024); This does not fix the issue. You're casting, but the value does not fit in 32 bit and the warning still remains. I am afraid that 32 bit for gd->ram_size are not enough anymore... We can fix the warning setting maybe a lower amout of memory (I am expecting that now the value is truncated and a wrong output is shown on the console), but for the future gd->ram_size should move to 64 bit. Best regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================