public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel
Date: Sat, 16 Mar 2013 09:13:40 -0700	[thread overview]
Message-ID: <51449A34.7080902@boundarydevices.com> (raw)
In-Reply-To: <CAOMZO5CoAc__NYRB+KU1iho9GsW2A++AkatGu9M8+x2H3WatKA@mail.gmail.com>

On 03/16/2013 07:58 AM, Fabio Estevam wrote:
> Hi Eric,
>
> On Fri, Mar 15, 2013 at 9:20 PM, Eric Nelson
> <eric.nelson@boundarydevices.com> wrote:
>
>> This is the **board** revision, right?
>>
>> At first glance, the kernel seems to be getting the silicon revision
>> from the same place as get_cpu_rev():
>>
>> https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.0.35_1.1.1/arch/arm/mach-mx6/cpu.c#L51
>>
>> http://git.denx.de/u-boot.git/?p=u-boot.git;a=blob;f=arch/arm/cpu/armv7/mx6/soc.c;h=a8aad5dd0a6c8548277021ebe8f6e159dbf31b9b;hb=HEAD#l42
>>
>> Is there a reference to the ATAG that I'm not seeing somewhere?
>
> Ok, so 3.0.35 treats cpu_rev correctly and do not assume this info to
> be passed from the bootloader. I was confused with 2.6.35, where I had
> issues with this on mx53.
>
> So, it seems that nitrogen does not need to pass get_board_rev() at all then?
>
At the moment, it doesn't.

I would really like to see us (the i.MX6 community) standardize
the use of some fuses to specifically mean board revision.

We're contemplating some board changes such as switching the
ethernet PHY and having a convention for the use of a few
bits in OTP would allow us to implement get_board_rev() once in
a common place.

Over the lifetime of most boards, it's likely that at least
one board revision will have software implications and having
a common way to express/detect this could prevent some churn
in board-specific files.

Such a convention would need to have broad sign off though.

Let me know your thoughts on the subject.

Regards,


Eric

  reply	other threads:[~2013-03-16 16:13 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-15 21:06 [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel Fabio Estevam
2013-03-15 21:06 ` [U-Boot] [PATCH 2/2] mx6qsabrelite: Do not hardcode the CPU revision Fabio Estevam
2013-03-16  5:59   ` Dirk Behme
2013-03-16  8:19     ` Wolfgang Denk
2013-03-16 14:50     ` Fabio Estevam
2013-03-16 14:52       ` Otavio Salvador
2013-03-16 15:01         ` Fabio Estevam
2013-03-16 16:32           ` Otavio Salvador
2013-03-16 19:41     ` Fabio Estevam
2013-03-16  0:20 ` [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel Eric Nelson
2013-03-16 14:58   ` Fabio Estevam
2013-03-16 16:13     ` Eric Nelson [this message]
2013-03-16 16:55       ` Dirk Behme
2013-03-16 20:17         ` Wolfgang Denk
2013-03-16 19:48       ` Fabio Estevam
2013-03-16 20:27         ` Eric Nelson
2013-03-25 19:14           ` Eric Nelson
2013-03-26  2:25             ` Fabio Estevam
2013-03-26  3:27               ` Fabio Estevam
2013-03-16 20:29         ` Wolfgang Denk
2013-03-16 20:14       ` Wolfgang Denk
2013-03-26 15:24 ` Eric Nelson
2013-03-26 15:26   ` Eric Nelson
2013-03-26 18:06   ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51449A34.7080902@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox