From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adnan Ali Date: Tue, 19 Mar 2013 15:25:47 +0000 Subject: [U-Boot] [PATCH v8] Introduced btrfs file-system with btrload command In-Reply-To: <20130319143504.GE25919@bill-the-cat> References: <1363613000-29473-1-git-send-email-adnan.ali@codethink.co.uk> <1363613000-29473-2-git-send-email-adnan.ali@codethink.co.uk> <20130319143504.GE25919@bill-the-cat> Message-ID: <5148837B.1020208@codethink.co.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi On 19/03/13 14:35, Tom Rini wrote: > On Mon, Mar 18, 2013 at 01:23:20PM +0000, Adnan Ali wrote: > >> Introduces btrfs file-system to read file from >> volume/sub-volumes with btrload command. This >> implementation has read-only support. >> This btrfs implementation is based on syslinux btrfs >> code, commit 269ebc845ebc8b46ef4b0be7fa0005c7fdb95b8d. >> >> v8: patch re-formated. >> v7: patch re-formated. >> v6: patch re-formated. >> v5: merged with master. >> v4: btrls command added. >> >> Signed-off-by: Adnan Ali > I'm sorry, but there's still some pretty severe checkpatch warnings > introduced here over syslinux such as: > ERROR: do not use assignment in if condition > #525: FILE: btrfs/btrfs.c:525: > + if (status = btrfs_comp_keys_type(&search_key, > > Please use "./tools/checkpatch.pl -f fs/btrfs/btrfs.c" and -f > /path/to/syslinux/core/fs/btrfs/btrfs.c and fix the things that are > being introduced and quite possibly bugs like the above. > Thanks, I am going to remove all the errors. Do you want me to remove all warnings as well or you are fine with it. This has taken quite a while now. Thanks Adnan Ali