public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: mx6qsabrelite: fsl_esdhc: Define maximum bus width supported by SabreLite board
Date: Thu, 21 Mar 2013 09:17:08 -0700	[thread overview]
Message-ID: <514B3284.3070702@boundarydevices.com> (raw)
In-Reply-To: <1363847901-29146-1-git-send-email-abbas_raza@mentor.com>

Thanks Abbas,

On 03/20/2013 11:38 PM, Abbas Raza wrote:
> From: Abbas Raza <Abbas_Raza@mentor.com>
>
> Maximum bus width supported by SabreLite board is not 8bit like
> all other mx6q specific boards. In case where both host controller
> and card support 8bit transfers, they agree to communicate on 8bit
> interface while boards like the SabreLite support only 4bit interface.
> Due to this reason the mmc 8bit default mode fails on the SabreLite.
> To rectify this, define maximum bus width supported by this board (4bit).
> If max_bus_width is not defined, it is 0 by default and 8bit width support
> will be enabled in host capabilities otherwise host capabilities are modified
> accordingly.
>
> It is tested with a MMCplus card.
>
> Signed-off-by: Abbas Raza <Abbas_Raza@mentor.com>
> cc: stefano Babic <sbabic@denx.de>
> cc: Andy Fleming <afleming@gmail.com>
> Acked-by: Dirk Behme <dirk.behme@de.bosch.com>
> Acked-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
> ---
>   board/freescale/mx6qsabrelite/mx6qsabrelite.c | 3 +++
>   drivers/mmc/fsl_esdhc.c                       | 7 +++++++
>   include/fsl_esdhc.h                           | 1 +
>   3 files changed, 11 insertions(+)
>

Tested-by: Eric Nelson <eric.nelson@boundarydevices.com>

Note that the board settings also apply to nitrogen6x and wandboard
if you want to expand the patch a bit:

	http://git.denx.de/u-boot.git/?p=u-boot/u-boot-imx.git;a=blob;f=board/boundary/nitrogen6x/nitrogen6x.c;h=229c2378396d43a365d6682af35c0e519ccd69d4;hb=HEAD#l304
	http://git.denx.de/u-boot.git/?p=u-boot/u-boot-imx.git;a=blob;f=board/wandboard/wandboard.c;h=d95189f77de4c3573ec30c53e04fe1b083c1d2b5;hb=HEAD#l107

I also tested against a custom board with 8-bit eMMC.

Regards,


Eric

  reply	other threads:[~2013-03-21 16:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-21  6:38 [U-Boot] [PATCH] mmc: mx6qsabrelite: fsl_esdhc: Define maximum bus width supported by SabreLite board Abbas Raza
2013-03-21 16:17 ` Eric Nelson [this message]
2013-03-25 11:02   ` Abbas Raza
2013-03-25 13:52     ` Eric Nelson
2013-06-06 20:25     ` Eric Nelson
2013-06-06 21:47       ` Otavio Salvador
  -- strict thread matches above, loose matches on Subject: below --
2013-03-21 11:00 Abbas Raza
2013-04-03  9:06 ` Stefano Babic
2013-04-03  9:18   ` Dirk Behme
2013-04-03  9:52     ` Stefano Babic
2013-04-03  9:27   ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514B3284.3070702@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox