From: Manfred Huber <man.huber@arcor.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] omap3_beagle: Enable CONFIG_SYS_NS16550_BROKEN_TEMT
Date: Thu, 21 Mar 2013 20:03:59 +0100 [thread overview]
Message-ID: <514B599F.8040804@arcor.de> (raw)
In-Reply-To: <CABxcv=kCxx+S6D12C9GKFdPF5aJPs5T6o+WdbA5_ZXYFGd2owQ@mail.gmail.com>
From: Manfred Huber
Beagleboard UART (ns16550) doesn't set the Transmitter Empty (TEMT) Bit
in SPL. Only Transmitter Hold Register Empty (THRE) Bit is set. This
makes SPL to hang while waiting for TEMT. Adding the
CONFIG_SYS_NS16550_BROKEN_TEMT config option and waiting for THRE avoid
this issue.
Signed-off-by: Manfred Huber <man.huber@arcor.de>
---
drivers/serial/ns16550.c | 5 ++++-
include/configs/omap3_beagle.h | 3 +++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
index b2da8b3..6379bcc 100644
--- a/drivers/serial/ns16550.c
+++ b/drivers/serial/ns16550.c
@@ -36,7 +36,10 @@
void NS16550_init(NS16550_t com_port, int baud_divisor)
{
-#if (!defined(CONFIG_SYS_NS16550_BROKEN_TEMT))
+#if defined(CONFIG_SPL_BUILD) && defined(CONFIG_SYS_NS16550_BROKEN_TEMT)
+ while (!(serial_in(&com_port->lsr) & UART_LSR_THRE))
+ ;
+#else
while (!(serial_in(&com_port->lsr) & UART_LSR_TEMT))
;
#endif
diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
index 48ce4c0..6ab46d5 100644
--- a/include/configs/omap3_beagle.h
+++ b/include/configs/omap3_beagle.h
@@ -82,6 +82,9 @@
#define CONFIG_SYS_NS16550_REG_SIZE (-4)
#define CONFIG_SYS_NS16550_CLK V_NS16550_CLK
+/* define to avoid U-Boot to hang while waiting for TEMT */
+#define CONFIG_SYS_NS16550_BROKEN_TEMT
+
/*
* select serial console configuration
*/
next prev parent reply other threads:[~2013-03-21 19:03 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 13:09 [U-Boot] Beagleboard: SPL hangs on serial init man.huber at arcor.de
2013-03-16 13:13 ` Manfred Huber
2013-03-19 14:49 ` Tom Rini
2013-03-19 23:52 ` Manfred Huber
2013-03-20 0:05 ` Javier Martinez Canillas
2013-03-20 1:27 ` Tom Rini
2013-03-20 23:09 ` Manfred Huber
2013-03-21 21:08 ` Javier Martinez Canillas
2013-03-23 10:11 ` Manfred Huber
2013-03-21 19:03 ` Manfred Huber [this message]
2013-03-21 21:28 ` [U-Boot] [PATCH] omap3_beagle: Enable CONFIG_SYS_NS16550_BROKEN_TEMT Javier Martinez Canillas
2013-03-21 22:21 ` Tom Rini
2013-03-21 22:28 ` Scott Wood
2013-03-25 22:02 ` [U-Boot] [PATCH 1/1 v2] omap3_beagle: Enabling UART3 first allows the Transmitter to be empty Manfred Huber
2013-03-27 4:50 ` Manfred Huber
2013-03-27 9:29 ` Javier Martinez Canillas
2013-03-27 13:57 ` Tom Rini
2013-03-28 5:55 ` Manfred Huber
2013-03-29 8:19 ` Manfred Huber
2013-03-28 15:21 ` Tom Rini
2013-03-27 13:37 ` Andreas Bießmann
2013-03-27 17:22 ` Javier Martinez Canillas
2013-03-28 6:06 ` Manfred Huber
2013-03-28 8:45 ` Andreas Bießmann
2013-03-28 9:11 ` Javier Martinez Canillas
2013-03-28 9:50 ` Andreas Bießmann
2013-03-28 15:21 ` Tom Rini
2013-03-29 8:33 ` Manfred Huber
2013-03-29 9:20 ` [U-Boot] [PATCH 1/1 v3] " Manfred Huber
2013-03-29 9:43 ` Albert ARIBAUD
2013-03-29 12:34 ` Tom Rini
2013-03-29 12:42 ` [U-Boot] [PATCH 1/1 v4] omap3_beagle: Flush UART3 xmit on enable if TEMT is broken Manfred Huber
2013-03-29 12:52 ` [U-Boot] [PATCH 1/1 v5] " Manfred Huber
2013-04-02 7:46 ` Javier Martinez Canillas
2013-04-02 8:59 ` Andreas Bießmann
2013-04-08 16:56 ` [U-Boot] [U-Boot, 1/1, " Tom Rini
2013-04-10 22:12 ` [U-Boot] [PATCH v1 1/1] omap3: Display MHz instead of mHz on the console Manfred Huber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514B599F.8040804@arcor.de \
--to=man.huber@arcor.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox