From mboxrd@z Thu Jan  1 00:00:00 1970
From: York Sun <yorksun@freescale.com>
Date: Thu, 21 Mar 2013 13:38:37 -0700
Subject: [U-Boot] [RFC] MAKEALL: Fix case substitution for old bash
In-Reply-To: <20130321202835.GA2575@badger>
References: <1363895895-31596-1-git-send-email-yorksun@freescale.com>
	<20130321202835.GA2575@badger>
Message-ID: <514B6FCD.9060703@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 03/21/2013 01:28 PM, Allen Martin wrote:
> On Thu, Mar 21, 2013 at 12:58:15PM -0700, York Sun wrote:
>> Bash ver 3.x doesn't support the parameter expansion with case
>> substitution. Use tr instead.
>>
>> Signed-off-by: York Sun <yorksun@freescale.com>
>> ---
>> I am not sure if using 'tr' is a good idea. Any suggestion is welcomed.
>>
>>  MAKEALL |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/MAKEALL b/MAKEALL
>> index c1d8957..ac92ef6 100755
>> --- a/MAKEALL
>> +++ b/MAKEALL
>> @@ -664,7 +664,7 @@ build_target() {
>>  	export BUILD_DIR="${output_dir}"
>>  
>>  	target_arch=$(get_target_arch ${target})
>> -	eval cross_toolchain=\$CROSS_COMPILE_${target_arch^^}
>> +	eval cross_toolchain=\$CROSS_COMPILE_`echo $target_arch | tr '[:lower:]' '[:upper:]'`
> 
> Looks fine to me.  I'm not sure if there's a preference between using
> backtick or $() for shell commands, it looks like both are used in the
> script. 

Let's wait for others to chime in.

> 
>>  	if [ "${cross_toolchain}" ] ; then
>>  	    MAKE="make CROSS_COMPILE=${cross_toolchain}"
>>  	elif [ "${CROSS_COMPILE}" ] ; then
>> -- 
>> 1.7.9.5
>>
>>
> 
> PS: What happened with your bool fixup patch?  I'm a big fan of that
> patch :^)
> 

Tom asked on March 4th. I think he will accept it.

York