From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Patch sets coming
Date: Fri, 22 Mar 2013 14:33:59 -0700 [thread overview]
Message-ID: <514CCE47.3060408@freescale.com> (raw)
In-Reply-To: <20130322212507.GM26945@bill-the-cat>
On 03/22/2013 02:25 PM, Tom Rini wrote:
> On Fri, Mar 22, 2013 at 10:17:03PM +0100, Wolfgang Denk wrote:
>> Dear York Sun,
>>
>> In message <514CC7B1.2070706@freescale.com> you wrote:
>>>
>>> Will fix. I often found unsure about some warnings, not knowing if
>>> u-boot follow exactly the same standard. Beside, some old patches may
>>> pass checkpatch then but fails today.
>>
>> Well, you are supposed to run checkpatch _today_, before posting, and
>> fix such issues.
>>
>> There may be a few cases where you intentionally ignore such fixes
>> (like lines over 80 characters in tables of pin-muxc initializations,
>> where wrapping the code would make it even worse to read), but such
>> exceptions and your reasoning should be metioned in the comments.
>
> To be clear, I know of 2 cases checkpatch.pl gets wrong today and I have
> patches for both to push to correct this:
> http://patchwork.ozlabs.org/patch/228173/
> http://patchwork.ozlabs.org/patch/227717/
>
> Aside from that, it's once again checkpatch is correct unless obviously
> wrong (first patch for example) and we should fix .checkpatch.conf so it
> stops being wrong.
>
Thanks, Tom. I was using checkpatch from linux. Will use
tools/checkpatch.pl from now on.
York
next prev parent reply other threads:[~2013-03-22 21:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 16:38 [U-Boot] Patch sets coming York Sun
2013-03-22 16:38 ` [U-Boot] [PATCH 01/10] doc/ramboot.mpc85xx: Documented the RAMBOOT for MPC85xx York Sun
2013-03-22 16:38 ` [U-Boot] [PATCH 02/10] qoriq/p1_p2_rdb_pc: USB device-tree fixups for P1020 York Sun
2013-03-22 16:38 ` [U-Boot] [PATCH 03/10] powerpc/85xx: add SerDes bank 4 lanes only if we have a bank 4 York Sun
2013-03-22 16:38 ` [U-Boot] [PATCH 04/10] powerpc/p1010rdb: Change flexcan compatible string York Sun
2013-03-22 16:38 ` [U-Boot] [PATCH 05/10] powerpc/p1010rdb: add readme document for p1010rdb York Sun
2013-03-22 16:38 ` [U-Boot] [PATCH 06/10] powerpc/mpc85xx: Extend workaround for erratum DDR_A003 to other SoCs York Sun
2013-03-22 16:38 ` [U-Boot] [PATCH 07/10] Changed LIODN offset values York Sun
2013-03-22 16:38 ` [U-Boot] [PATCH 08/10] powerpc/p1_p2_rdb_pc: Add a pin to reset the DDR chip for P1021RDB-PC York Sun
2013-03-22 16:38 ` [U-Boot] [PATCH 09/10] powerpc/corenet_ds: Move SRIO enablement into specific boards York Sun
2013-03-22 16:38 ` [U-Boot] [PATCH 10/10] powerpc/85xx: set USB2 default mode to 'device' for (super)hydra boards York Sun
2013-03-22 20:45 ` [U-Boot] Patch sets coming Wolfgang Denk
2013-03-22 21:05 ` York Sun
2013-03-22 21:17 ` Wolfgang Denk
2013-03-22 21:25 ` Tom Rini
2013-03-22 21:33 ` York Sun [this message]
2013-03-22 21:43 ` York Sun
2013-03-22 22:45 ` Tom Rini
2013-03-22 22:55 ` York Sun
2013-03-23 1:09 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514CCE47.3060408@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox