From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sricharan R <r.sricharan@ti.com>
Date: Mon, 25 Mar 2013 23:17:50 +0530
Subject: [U-Boot] [PATCH V2 0/9] OMAP3-5: TWL[46]03[05]: cleanup
 register access and misc minimal cleanups
In-Reply-To: <1363988004-25819-1-git-send-email-nm@ti.com>
References: <1363988004-25819-1-git-send-email-nm@ti.com>
Message-ID: <51508DC6.2090304@ti.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Nishanth,

On Saturday 23 March 2013 03:03 AM, Nishanth Menon wrote:
> V1: http://patchwork.ozlabs.org/patch/227112/
> 
> This series helps standardize register parameters for TWL4030, 6030 and 6035
> used in various OMAP3,4,5 based platforms.
> For historical reasons, we have been following val, reg as the order of
> parameters while we have reg, val in every other i2c apis including i2c
> mw/mr command @ u-boot cmd line, with kernel APIs, i2cget, i2cset utilities.
> 
> Instead of maintaining this forked implementation, it is never too late to
> fix them.
> 
> Build tested (MAKEALL) platforms-at least these seem to be be impacted ones:
> cm_t35
> devkit8000
> dig297
> igep0020            
> igep0020_nand       
> igep0030            
> igep0030_nand       
> nokia_rx51
> omap3_beagle
> omap3_evm
> omap3_evm_quick_mmc
> omap3_evm_quick_nand
> omap3_logic
> omap3_mvblx
> omap3_overo
> omap3_pandora
> omap3_sdp3430
> omap3_zoom1
> omap3_zoom2
> omap4_panda
> omap4_sdp4430
> omap5_evm
> tricorder
> 
> Boot tested platforms (upto kernel+shell with dtb):
> omap3_beagle - tested on beagle XM (C1), beagle(C1D) - TWL4030
> omap4_panda - tested on PandaBoard(A3) and PandaBoard-ES(EB3) - TWL6030
> omap5_evm - OMAP5 uEVM - TWL6035
> 
> twl4030 changes are little wider in scope, so I have split them
> into two patches to help review
> 
> Series is based on u-boot master:
>  master      8b906a9 Merge branch 'spi' of git://git.denx.de/u-boot-x86
> (rationale being the changes if done on v2013.04-rc1 have much changes to
>  allow this series to apply cleanly on the latest)
> 
> NOTE: the series tries to maintain existing indentation style to allow the
> code to stay in sync with legacy code.
> 
> Nishanth Menon (9):
>   twl4030: make twl4030_i2c_write_u8 prototype consistent
>   twl4030: make twl4030_i2c_read_u8 prototype consistent
>   twl6030: twl6030_i2c_[read|write]_u8 prototype consistent
>   twl6030: move twl6030 register access functions to common header file
>   twl6030: add header guard
>   twl6035: make twl6030_i2c_[read|write]_u8 static inline
>   twl6035: twl6035_i2c_[read|write]_u8 prototype consistent
>   twl6035: remove redundant palmas_[read|write]_u8
>   twl6035: add header guard
> 
>  board/cm_t35/cm_t35.c      |   24 +++++++-------
>  board/nokia/rx51/rx51.c    |   52 +++++++++++++++---------------
>  board/pandora/pandora.c    |    3 +-
>  drivers/misc/twl4030_led.c |    4 +--
>  drivers/power/twl4030.c    |   16 +++++-----
>  drivers/power/twl6030.c    |   75 +++++++++++++++++++-------------------------
>  drivers/power/twl6035.c    |   26 ++-------------
>  drivers/usb/phy/twl4030.c  |   48 ++++++++++++++--------------
>  include/twl4030.h          |    4 +--
>  include/twl6030.h          |   16 ++++++++++
>  include/twl6035.h          |   18 +++++++++--
>  11 files changed, 142 insertions(+), 144 deletions(-)
> 
> Regards,
> Nishanth Menon
   All of TWL[46]03[05]_i2c_[write/read]_u8 is doing the same. (ie)
      i2c_write(chip_no, reg, 1, &val, 1);
      i2c_read(chip_no, reg, 1, val, 1);

    We always seem to use 1 byte addresses and length.
   
    Then why can't we move to to twl_common.h and use just one function
    every where ?

    Otherwise, this is a required cleanup.

    Reviewed-by: R Sricharan <r.sricharan@ti.com>

Regards,
 Sricharan