From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel
Date: Tue, 26 Mar 2013 08:26:15 -0700 [thread overview]
Message-ID: <5151BE17.8040705@boundarydevices.com> (raw)
In-Reply-To: <5151BDB1.10201@boundarydevices.com>
On 03/26/2013 08:24 AM, Eric Nelson wrote:
> Hi Fabio,
>
> <snip>
>
>> --- a/board/boundary/nitrogen6x/nitrogen6x.c
>> +++ b/board/boundary/nitrogen6x/nitrogen6x.c
>> @@ -330,7 +330,7 @@ int board_mmc_init(bd_t *bis)
>>
>> u32 get_board_rev(void)
>> {
>> - return 0x63000;
>> + return get_cpu_rev();
>> }
>>
>> #ifdef CONFIG_MXC_SPI
>>
>
> Since this convention is shared among at least SABRE Lite, SABRE SD,
> Nitrogen6x and Wandboard, wouldn't a weak function in imx-common/cpu.c
> be a better choice?
>
Oops.
I meant to say arch/arm/cpu/armv7/mx6/soc.c, not imx-common/cpu.c.
next prev parent reply other threads:[~2013-03-26 15:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 21:06 [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel Fabio Estevam
2013-03-15 21:06 ` [U-Boot] [PATCH 2/2] mx6qsabrelite: Do not hardcode the CPU revision Fabio Estevam
2013-03-16 5:59 ` Dirk Behme
2013-03-16 8:19 ` Wolfgang Denk
2013-03-16 14:50 ` Fabio Estevam
2013-03-16 14:52 ` Otavio Salvador
2013-03-16 15:01 ` Fabio Estevam
2013-03-16 16:32 ` Otavio Salvador
2013-03-16 19:41 ` Fabio Estevam
2013-03-16 0:20 ` [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel Eric Nelson
2013-03-16 14:58 ` Fabio Estevam
2013-03-16 16:13 ` Eric Nelson
2013-03-16 16:55 ` Dirk Behme
2013-03-16 20:17 ` Wolfgang Denk
2013-03-16 19:48 ` Fabio Estevam
2013-03-16 20:27 ` Eric Nelson
2013-03-25 19:14 ` Eric Nelson
2013-03-26 2:25 ` Fabio Estevam
2013-03-26 3:27 ` Fabio Estevam
2013-03-16 20:29 ` Wolfgang Denk
2013-03-16 20:14 ` Wolfgang Denk
2013-03-26 15:24 ` Eric Nelson
2013-03-26 15:26 ` Eric Nelson [this message]
2013-03-26 18:06 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5151BE17.8040705@boundarydevices.com \
--to=eric.nelson@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox