public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] unaligned access in part_efi.c
Date: Wed, 27 Mar 2013 12:23:22 -0600	[thread overview]
Message-ID: <5153391A.1010201@wwwdotorg.org> (raw)
In-Reply-To: <19802419.J2rqQhB4h6@ax5200p>

On 03/26/2013 02:42 PM, Marc Dietrich wrote:
> Hi,
> 
> access to part->start_sect in pmbr_part_valid() (form disk/part_efi.c) and 
> propably other positions/fields causes an unaligned access on ARM (tegra in my 
> case) and a uboot crash. This was introduced by commit fae2bf22 [1] which 
> changed le32_to_int (which is a byte access) to le32_to_cpu (which is a 32bit 
> access).

I can't reproduce this with latest u-boot-arm/master, which includes
that commit. Both "mmc dev N; mmc rescan ; mmcinfo" and "part list mmc
N" work fine for me with both DOS PT and GPT.

I did test this on a Tegra Seaboard which isn't identical to the AC100,
but the only practical difference is 512M vs 1G RAM, which seems
unlikely to cause this.

It'd help if you pointed out exactly which access causes the issue;
which piece of code is failing. The most likely issue is that some
memory buffer is assumed to be aligned to 4-bytes, but actually isn't.
To track that down, we'd need to know which code and which buffer. Also,
a disassembly of the problematic function would be useful.

  reply	other threads:[~2013-03-27 18:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-26 20:42 [U-Boot] unaligned access in part_efi.c Marc Dietrich
2013-03-27 18:23 ` Stephen Warren [this message]
2013-03-27 21:46   ` Marc Dietrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5153391A.1010201@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox