From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mx6: Fix get_board_rev() for the mx6 solo case
Date: Wed, 27 Mar 2013 13:02:01 -0700 [thread overview]
Message-ID: <51535039.5030203@boundarydevices.com> (raw)
In-Reply-To: <51534CE0.4040305@gmail.com>
Hi Dirk,
On 03/27/2013 12:47 PM, Dirk Behme wrote:
> Am 27.03.2013 20:36, schrieb Fabio Estevam:
>> Hi Dirk,
>>
>> On Wed, Mar 27, 2013 at 3:56 PM, Dirk Behme <dirk.behme@gmail.com> wrote:
>>
>>> This is much better than changing Troy's get_cpu_rev(). Thanks :)
>>
>> I am glad you like it :-)
>>
>>>
>>> But what's about to add this code to
>>>
>>> http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/tree/arch/arm/kernel/setup.c?h=imx_3.0.35_1.1.0#n655
>>>
>>
>> Because I cannot post a patch in the U-boot list to fix an internal
>> FSL kernel :-)
>>
>> I can certainly suggest this (and yes, I fully agree that the kernel
>> should handle the CPU detection without relying at the bootloader at
>> all), but from a U-boot perspective we cannot really know which kernel
>> version the user will deploy.
>>
>> If we want mainline U-boot to work with this particular kernel version
>> on mx6 solo, then we need to adjust ATAGS as proposed by my patch.
>
> Ok, sounds reasonable, agreed.
>
> Even if someone might complain that this is off-topic here, again ( ;)
> ): Do you like to check if the recent _mainline_ kernel wants something
> similar?
>
It wasn't a complaint from me, but I can assure you that the
offending bit of code that I found (in imx-lib) won't function
against a main-line kernel without some serious re-work.
Regards,
Eric
next prev parent reply other threads:[~2013-03-27 20:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 17:36 [U-Boot] [PATCH v2] mx6: Fix get_board_rev() for the mx6 solo case Fabio Estevam
2013-03-27 18:56 ` Dirk Behme
2013-03-27 19:36 ` Fabio Estevam
2013-03-27 19:47 ` Dirk Behme
2013-03-27 20:02 ` Eric Nelson [this message]
2013-03-28 7:04 ` Dirk Behme
2013-03-28 13:58 ` Eric Nelson
2013-04-03 9:36 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51535039.5030203@boundarydevices.com \
--to=eric.nelson@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox