From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Nelson Date: Wed, 27 Mar 2013 13:02:01 -0700 Subject: [U-Boot] [PATCH v2] mx6: Fix get_board_rev() for the mx6 solo case In-Reply-To: <51534CE0.4040305@gmail.com> References: <1364405816-14085-1-git-send-email-fabio.estevam@freescale.com> <515340E4.40706@gmail.com> <51534CE0.4040305@gmail.com> Message-ID: <51535039.5030203@boundarydevices.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Dirk, On 03/27/2013 12:47 PM, Dirk Behme wrote: > Am 27.03.2013 20:36, schrieb Fabio Estevam: >> Hi Dirk, >> >> On Wed, Mar 27, 2013 at 3:56 PM, Dirk Behme wrote: >> >>> This is much better than changing Troy's get_cpu_rev(). Thanks :) >> >> I am glad you like it :-) >> >>> >>> But what's about to add this code to >>> >>> http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/tree/arch/arm/kernel/setup.c?h=imx_3.0.35_1.1.0#n655 >>> >> >> Because I cannot post a patch in the U-boot list to fix an internal >> FSL kernel :-) >> >> I can certainly suggest this (and yes, I fully agree that the kernel >> should handle the CPU detection without relying at the bootloader at >> all), but from a U-boot perspective we cannot really know which kernel >> version the user will deploy. >> >> If we want mainline U-boot to work with this particular kernel version >> on mx6 solo, then we need to adjust ATAGS as proposed by my patch. > > Ok, sounds reasonable, agreed. > > Even if someone might complain that this is off-topic here, again ( ;) > ): Do you like to check if the recent _mainline_ kernel wants something > similar? > It wasn't a complaint from me, but I can assure you that the offending bit of code that I found (in imx-lib) won't function against a main-line kernel without some serious re-work. Regards, Eric