* [U-Boot] dm9000 patch tftp, nfs fixes. @ 2013-03-25 16:43 Chris Ruehl 2013-03-28 21:50 ` Tom Rini 0 siblings, 1 reply; 3+ messages in thread From: Chris Ruehl @ 2013-03-25 16:43 UTC (permalink / raw) To: u-boot Hi, I start a project on a freescale imx27 using the dm9000a for network. I learned that the tftp , nfs and other network related working more less very unstable. I start compare the dm9000.c code with the upstream kernel v3.8.4 and fix some issues. issues tftp with many bad checksums and timeouts nfs with not working at all when upload a 38Mbyte rootfs.jffs2 After the patch its works much better for me. please find my patch attached and consider to merge it the the head branch. cheers Chris -- GTSYS Limited RFID Technology Unit 958 , KITEC - 1 Trademart Drive - Kowloon Bay - Hong Kong Fax (852) 8167 4060 - Tel (852) 3598 9488 Disclaimer: http://www.gtsys.com.hk/email/classified.html -------------- next part -------------- A non-text attachment was scrubbed... Name: dm9000-hang.patch Type: text/x-patch Size: 6001 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130326/968ef68b/attachment.bin> ^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] dm9000 patch tftp, nfs fixes. 2013-03-25 16:43 [U-Boot] dm9000 patch tftp, nfs fixes Chris Ruehl @ 2013-03-28 21:50 ` Tom Rini 2013-03-29 5:32 ` Chris Ruehl 0 siblings, 1 reply; 3+ messages in thread From: Tom Rini @ 2013-03-28 21:50 UTC (permalink / raw) To: u-boot On Mon, Mar 25, 2013 at 06:43:34AM -0000, Chris Ruehl wrote: > Hi, > > I start a project on a freescale imx27 using the dm9000a for network. > > I learned that the tftp , nfs and other network related working more > less very unstable. I start compare the dm9000.c code with the > upstream kernel v3.8.4 and fix some issues. > > issues > tftp > with many bad checksums and timeouts > nfs > with not working at all when upload a 38Mbyte rootfs.jffs2 > > > After the patch its works much better for me. > please find my patch attached and consider to merge it the the head branch. [snip] > @@ -351,75 +353,82 @@ static int dm9000_eth_rx (struct eth_device *edev) > u32 tmplen, i; > u32 tmpdata; > > + udelay(2500); // we called in a loop to quick .. give me some time No // style comments, and "We were called into the loop too quickly". And I don't know if the big delay here is a good thing or not, without knowing the hardware. Jason, you've touched this driver recently and I assume know the hardware at least a little bit, can you comment here? For full context see http://patchwork.ozlabs.org/patch/230759/ thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130328/17eff4fa/attachment.pgp> ^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] dm9000 patch tftp, nfs fixes. 2013-03-28 21:50 ` Tom Rini @ 2013-03-29 5:32 ` Chris Ruehl 0 siblings, 0 replies; 3+ messages in thread From: Chris Ruehl @ 2013-03-29 5:32 UTC (permalink / raw) To: u-boot On Friday, March 29, 2013 05:50 AM, Tom Rini wrote: > On Mon, Mar 25, 2013 at 06:43:34AM -0000, Chris Ruehl wrote: > >> Hi, >> >> I start a project on a freescale imx27 using the dm9000a for network. >> >> I learned that the tftp , nfs and other network related working more >> less very unstable. I start compare the dm9000.c code with the >> upstream kernel v3.8.4 and fix some issues. >> >> issues >> tftp >> with many bad checksums and timeouts >> nfs >> with not working at all when upload a 38Mbyte rootfs.jffs2 >> >> >> After the patch its works much better for me. >> please find my patch attached and consider to merge it the the head branch. > [snip] >> @@ -351,75 +353,82 @@ static int dm9000_eth_rx (struct eth_device *edev) >> u32 tmplen, i; >> u32 tmpdata; >> >> + udelay(2500); // we called in a loop to quick .. give me some time > > No // style comments, and "We were called into the loop too quickly". > > And I don't know if the big delay here is a good thing or not, without > knowing the hardware. Jason, you've touched this driver recently and I > assume know the hardware at least a little bit, can you comment here? > For full context see http://patchwork.ozlabs.org/patch/230759/ thanks! > Tom, yeah, .. sorry about the style, I'd missed the comment .. ( I gonna fix this and resend my patch later ..) you right about its hardware dependency, on the mx27 @ 400Mhz I tried it with delays from 1000-3000 where 2500 give me the best result. Without a delay its end up in tftp *TTTT#.. and NFS is not working at all. Chris ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-29 5:32 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-03-25 16:43 [U-Boot] dm9000 patch tftp, nfs fixes Chris Ruehl 2013-03-28 21:50 ` Tom Rini 2013-03-29 5:32 ` Chris Ruehl
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox