public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Exynos5: clock: Fix a typo bug in exynos clock init
Date: Fri, 29 Mar 2013 20:38:23 +0900	[thread overview]
Message-ID: <51557D2F.5080905@samsung.com> (raw)
In-Reply-To: <1363867993-12327-1-git-send-email-akshay.s@samsung.com>

On 21/03/13 21:13, Akshay Saraswat wrote:
> We intended to clear the bits of CLK_SRC_TOP2 register, instead we were
> writing on the reserved bits of src_core1 register. Since the default
> value of clk_src_top2 register were itself zero, this typo was not
> creating any big issue. But it is better to fix this error for better
> readability of the code.
> 
> Signed-off-by: Hatim Ali <hatim.rv@samsung.com>
> Signed-off-by: Akshay Saraswat <akshay.s@samsung.com>
> ---
>  board/samsung/smdk5250/clock_init.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/board/samsung/smdk5250/clock_init.c b/board/samsung/smdk5250/clock_init.c
> index c009ae5..0ee65ae 100644
> --- a/board/samsung/smdk5250/clock_init.c
> +++ b/board/samsung/smdk5250/clock_init.c
> @@ -434,10 +434,10 @@ void system_clock_init()
>  		val = readl(&clk->mux_stat_core1);
>  	} while ((val | MUX_MPLL_SEL_MASK) != val);
>  
> -	clrbits_le32(&clk->src_core1, MUX_CPLL_SEL_MASK);
> -	clrbits_le32(&clk->src_core1, MUX_EPLL_SEL_MASK);
> -	clrbits_le32(&clk->src_core1, MUX_VPLL_SEL_MASK);
> -	clrbits_le32(&clk->src_core1, MUX_GPLL_SEL_MASK);
> +	clrbits_le32(&clk->src_top2, MUX_CPLL_SEL_MASK);
> +	clrbits_le32(&clk->src_top2, MUX_EPLL_SEL_MASK);
> +	clrbits_le32(&clk->src_top2, MUX_VPLL_SEL_MASK);
> +	clrbits_le32(&clk->src_top2, MUX_GPLL_SEL_MASK);
>  	tmp = MUX_CPLL_SEL_MASK | MUX_EPLL_SEL_MASK | MUX_VPLL_SEL_MASK
>  		| MUX_GPLL_SEL_MASK;
>  	do {
> 

applied to u-boot-samsung.

Thanks,
Minkyu Kang

      parent reply	other threads:[~2013-03-29 11:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-21 12:13 [U-Boot] [PATCH] Exynos5: clock: Fix a typo bug in exynos clock init Akshay Saraswat
2013-03-21 16:44 ` Simon Glass
2013-03-29 11:38 ` Minkyu Kang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51557D2F.5080905@samsung.com \
    --to=mk7.kang@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox