public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Manfred Huber <man.huber@arcor.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1 v4] omap3_beagle: Flush UART3 xmit on enable if TEMT is broken
Date: Fri, 29 Mar 2013 13:42:11 +0100	[thread overview]
Message-ID: <51558C23.1040003@arcor.de> (raw)
In-Reply-To: <CABxcv=kCxx+S6D12C9GKFdPF5aJPs5T6o+WdbA5_ZXYFGd2owQ@mail.gmail.com>

From: Manfred Huber <man.huber@arcor.de>

Flush UART3 xmit on enable if TEMT is broken

On some OMAP3 devices when UART3 is configured for boot mode before SPL starts 
only THRE bit is set. We have to empty the transmitter before initialization 
starts. This patch avoids the use of CONFIG_SYS_NS16550_BROKEN_TEMT.

Signed-off-by: Manfred Huber <man.huber@arcor.de>
---
Changes since v3:
	- Changed commit summary and added version history.

Changes since v2:
	- Removing CONFIG_SYS_NS16550_BROKEN_TEMT in README and igep00x0.h.

Changes since v1:
	- Replaced CONFIG_SYS_NS16550_BROKEN_TEMT with initial configuration of
	  UART.

README                     |    8 --------
 drivers/serial/ns16550.c   |   16 ++++++++++++++--
 include/configs/igep00x0.h |    3 ---
 3 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/README b/README
index a336476..e6b3a50 100644
--- a/README
+++ b/README
@@ -616,14 +616,6 @@ The following options need to be configured:
 		boot loader that has already initialized the UART.  Define this
 		variable to flush the UART at init time.
 
-		CONFIG_SYS_NS16550_BROKEN_TEMT
-
-		16550 UART set the Transmitter Empty (TEMT) Bit when all output
-		has finished and the transmitter is totally empty. U-Boot waits
-		for this bit to be set to initialize the serial console. On some
-		broken platforms this bit is not set in SPL making U-Boot to
-		hang while waiting for TEMT. Define this option to avoid it.
-
 
 - Console Interface:
 		Depending on board, define exactly one serial port

diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
index 87a0917..2922a2c 100644
--- a/drivers/serial/ns16550.c
+++ b/drivers/serial/ns16550.c
@@ -36,10 +36,22 @@
 
 void NS16550_init(NS16550_t com_port, int baud_divisor)
 {
-#if (!defined(CONFIG_SYS_NS16550_BROKEN_TEMT))
+#if (defined(CONFIG_SPL_BUILD) && defined(CONFIG_OMAP34XX))
+	/* On some OMAP3 devices when UART3 is configured for boot mode before
+	   SPL starts only THRE bit is set. We have to empty the transmitter
+	   before initialization starts. */
+	if ((serial_in(&com_port->lsr) & (UART_LSR_TEMT | UART_LSR_THRE))
+	     == UART_LSR_THRE) {
+		serial_out(UART_LCR_DLAB, &com_port->lcr);
+		serial_out(baud_divisor & 0xff, &com_port->dll);
+		serial_out((baud_divisor >> 8) & 0xff, &com_port->dlm);
+		serial_out(UART_LCRVAL, &com_port->lcr);
+		serial_out(0, &com_port->mdr1);
+	}
+#endif
+
 	while (!(serial_in(&com_port->lsr) & UART_LSR_TEMT))
 		;
-#endif
 
 	serial_out(CONFIG_SYS_NS16550_IER, &com_port->ier);
 #if (defined(CONFIG_OMAP) && !defined(CONFIG_OMAP3_ZOOM2)) || \

diff --git a/include/configs/igep00x0.h b/include/configs/igep00x0.h
index f8131b1..0617a58 100644
--- a/include/configs/igep00x0.h
+++ b/include/configs/igep00x0.h
@@ -67,9 +67,6 @@
 #define CONFIG_SYS_NS16550_REG_SIZE	(-4)
 #define CONFIG_SYS_NS16550_CLK		V_NS16550_CLK
 
-/* define to avoid U-Boot to hang while waiting for TEMT */
-#define CONFIG_SYS_NS16550_BROKEN_TEMT
-
 /* select serial console configuration */
 #define CONFIG_CONS_INDEX		3
 #define CONFIG_SYS_NS16550_COM3		OMAP34XX_UART3

  parent reply	other threads:[~2013-03-29 12:42 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-27 13:09 [U-Boot] Beagleboard: SPL hangs on serial init man.huber at arcor.de
2013-03-16 13:13 ` Manfred Huber
2013-03-19 14:49   ` Tom Rini
2013-03-19 23:52     ` Manfred Huber
2013-03-20  0:05     ` Javier Martinez Canillas
2013-03-20  1:27       ` Tom Rini
2013-03-20 23:09         ` Manfred Huber
2013-03-21 21:08           ` Javier Martinez Canillas
2013-03-23 10:11             ` Manfred Huber
2013-03-21 19:03       ` [U-Boot] [PATCH] omap3_beagle: Enable CONFIG_SYS_NS16550_BROKEN_TEMT Manfred Huber
2013-03-21 21:28         ` Javier Martinez Canillas
2013-03-21 22:21         ` Tom Rini
2013-03-21 22:28           ` Scott Wood
2013-03-25 22:02       ` [U-Boot] [PATCH 1/1 v2] omap3_beagle: Enabling UART3 first allows the Transmitter to be empty Manfred Huber
2013-03-27  4:50         ` Manfred Huber
2013-03-27  9:29           ` Javier Martinez Canillas
2013-03-27 13:57             ` Tom Rini
2013-03-28  5:55             ` Manfred Huber
2013-03-29  8:19             ` Manfred Huber
2013-03-28 15:21           ` Tom Rini
2013-03-27 13:37         ` Andreas Bießmann
2013-03-27 17:22           ` Javier Martinez Canillas
2013-03-28  6:06           ` Manfred Huber
2013-03-28  8:45             ` Andreas Bießmann
2013-03-28  9:11               ` Javier Martinez Canillas
2013-03-28  9:50                 ` Andreas Bießmann
2013-03-28 15:21                   ` Tom Rini
2013-03-29  8:33               ` Manfred Huber
2013-03-29  9:20       ` [U-Boot] [PATCH 1/1 v3] " Manfred Huber
2013-03-29  9:43         ` Albert ARIBAUD
2013-03-29 12:34           ` Tom Rini
2013-03-29 12:42       ` Manfred Huber [this message]
2013-03-29 12:52       ` [U-Boot] [PATCH 1/1 v5] omap3_beagle: Flush UART3 xmit on enable if TEMT is broken Manfred Huber
2013-04-02  7:46         ` Javier Martinez Canillas
2013-04-02  8:59         ` Andreas Bießmann
2013-04-08 16:56         ` [U-Boot] [U-Boot, 1/1, " Tom Rini
2013-04-10 22:12       ` [U-Boot] [PATCH v1 1/1] omap3: Display MHz instead of mHz on the console Manfred Huber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51558C23.1040003@arcor.de \
    --to=man.huber@arcor.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox