Re: [PATCH v4 00/17] IPv6 support

[Vyacheslav Mitrofanov V <v.v.mitrofanov@yadro.com>]

Tom, maybe it is better to change configs add ifdefs or do sth else to exclude them from the build if IPV6 is not configured?

Thanks!

________________________________
От: Vyacheslav Mitrofanov V
Отправлено: 29 ноября 2022 г. 11:35:13
Кому: Tom Rini
Копия: rfried.dev@gmail.com; joe.hershberger@ni.com; wd@denx.de; u-boot@lists.denx.de; judge.packham@gmail.com; linux@yadro.com; sjg@chromium.org
Тема: Re: [PATCH v4 00/17] IPv6 support


Hello Tom!
I tested this problem and I think it is necessary to set CONFIG_IPV6.
Without that option tests fail.

Thanks!

________________________________
От: Tom Rini <trini@konsulko.com>
Отправлено: 28 ноября 2022 г. 18:34:58
Кому: Vyacheslav Mitrofanov V
Копия: rfried.dev@gmail.com; joe.hershberger@ni.com; wd@denx.de; u-boot@lists.denx.de; judge.packham@gmail.com; linux@yadro.com; sjg@chromium.org
Тема: Re: [PATCH v4 00/17] IPv6 support

On Thu, Sep 08, 2022 at 02:58:48PM +0300, Viacheslav Mitrofanov wrote:

> This patch set adds basic IPv6 support to U-boot.
> It is based on Chris's Packham patches
> (https://lists.denx.de/pipermail/u-boot/2017-January/279366.html)
> Chris's patches were taken as base. There were efforts to launch it on
> HiFive SiFive Unmatched board but the board didn't work well. The code was
> refactored, fixed some bugs as CRC for little-endian, some parts were implemented in
> our own way, something was taken from Linux. Finally we did manual tests and the
> board worked well.
>
> Testing was done on HiFive SiFive Unmatched board (RISC-V)
>
> Signed-off-by: Viacheslav Mitrofanov <v.v.mitrofanov@yadro.com>
> ---
> Changes in v2:
>  - Split big patches into smaller
>  - If an address in tftpboot is IPv6 than use IPv6 to boot
>  - Add tests
>
> Changes in v3:
>  - Added functions and structures description in whole patch-series
>  - Removed memory allocation in on_ip6addr()
>  - Some functions got return code from errno.h
>  - Add to string_to_ip6() length parameter to avoid obligatory null termination
>  - Add a lot of small decorative cnages
>
> Changes in v4:
>  - Fixed funcs and structures style description
>  - Added omitted tags

Testing this locally in sandbox I see:
FAILED test/py/tests/test_ut.py::test_ut[ut_dm_dm_test_csum_ipv6_magic] - AssertionError: as...
FAILED test/py/tests/test_ut.py::test_ut[ut_dm_dm_test_ip6_addr_in_subnet] - AssertionError:...
FAILED test/py/tests/test_ut.py::test_ut[ut_dm_dm_test_ip6_make_lladdr] - assert False
FAILED test/py/tests/test_ut.py::test_ut[ut_dm_dm_test_ip6_make_snma] - assert False
FAILED test/py/tests/test_ut.py::test_ut[ut_dm_dm_test_string_to_ip6] - AssertionError: asse...
and this happens in CI as well:
https://source.denx.de/u-boot/u-boot/-/pipelines/14245
https://dev.azure.com/u-boot/u-boot/_build/results?buildId=5432&view=results

If you can't replicate the failures locally you should be able to
trigger CI:
https://u-boot.readthedocs.io/en/latest/develop/ci_testing.html

Thanks for pushing this along!

--
Tom