From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Tue, 02 Apr 2013 14:04:27 +0200 Subject: [U-Boot] [Patch v2] PHY: micrel.c: add support for KSZ9031 In-Reply-To: <1UKEBx-0000x3-4D@wolf.netmodule.com> References: <1360185517-9317-1-git-send-email-david.andrey@netmodule.com> <51388BA2.70604@denx.de> <1UKEBx-0000x3-4D@wolf.netmodule.com> Message-ID: <515AC94B.8070504@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi David, On 25.03.2013 21:39, David Andrey wrote: >> Why don't you just change the mask to support both PHY's with one > struct here? Something like this: >> >> static struct phy_driver ksz9021_driver = { >> - .name = "Micrel ksz9021", >> + .name = "Micrel ksz90x1", >> .uid = 0x221610, >> - .mask = 0xfffff0, >> + .mask = 0xffffc0, >> >> This would be much "simpler". Does it work for you? > > Well, because the ksz9031 works well with the generic phy config > function. See ksz9021_config vs genphy_config Okay, I see. Thanks. Acked-by: Stefan Roese Thanks, Stefan