From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v7] mtd: cfi_flash: Fix CFI flash driver for 8-bit bus support
Date: Tue, 02 Apr 2013 16:35:50 +0200 [thread overview]
Message-ID: <515AECC6.5030508@denx.de> (raw)
In-Reply-To: <5ac6f559-7da4-438b-9542-2a0b852f4424@CO1EHSMHS001.ehs.local>
On 03.03.2013 12:15, Jagannadha Sutradharudu Teki wrote:
> From: aaron.williams at caviumnetworks.com
>
> This commit is based on that patch from aaron.williams at caviumnetworks.com
> with same commit title. pulled the same code changes into current u-boot tree.
>
> http://patchwork.ozlabs.org/patch/140863/
> http://lists.denx.de/pipermail/u-boot/2011-April/089606.html
>
> This patch corrects the addresses used when working with Spansion/AMD FLASH chips.
> Addressing for 8 and 16 bits is almost identical except in the 16-bit case the
> LSB of the address is always 0. The confusion arose because the addresses
> in the datasheet for 16-bit mode are word addresses but this code assumed it was
> byte addresses.
>
> I have only been able to test this on our Octeon boards which use either an 8-bit
> or 16-bit bus. I have not tested the case where there's an 8-bit part on a 16-bit
> bus.
>
> This patch also adds some delays as suggested by Spansion.
>
> If a part can be both 8 and 16-bits, it forces it to work in 8-bit mode if an
> 8-bit bus is detected.
>
> Apart from the pulled changes, fixed few minor code cleanups and tested
> on 256M29EW, 512M29EW flashes.
>
> Before this fix:
> ---------------
> Bank # 1: CFI conformant flash (8 x 8) Size: 64 MB in 512 Sectors
> AMD Standard command set, Manufacturer ID: 0xFF, Device ID: 0xFF
> Erase timeout: 4096 ms, write timeout: 2 ms
> Buffer write timeout: 5 ms, buffer size: 1024 bytes
>
> After this fix:
> --------------
> Bank # 1: CFI conformant flash (8 x 8) Size: 64 MB in 512 Sectors
> AMD Standard command set, Manufacturer ID: 0x89, Device ID: 0x7E2301
> Erase timeout: 4096 ms, write timeout: 2 ms
> Buffer write timeout: 5 ms, buffer size: 1024 bytes
>
> Signed-off-by: Aaron Williams <aaron.williams@caviumnetworks.com>
> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
> Tested-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
Applied to u-boot-cfi-flash/master.
Thanks,
Stefan
next prev parent reply other threads:[~2013-04-02 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-03 11:15 [U-Boot] [PATCH v7] mtd: cfi_flash: Fix CFI flash driver for 8-bit bus support Jagannadha Sutradharudu Teki
2013-04-02 14:35 ` Stefan Roese [this message]
[not found] <1362309305-10413-1-git-send-email-jaganna@xilinx.com>
2013-03-27 10:22 ` Jagannadha Sutradharudu Teki
2013-04-02 12:34 ` Stefan Roese
2013-04-02 23:14 ` Aaron Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515AECC6.5030508@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox