From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] i.MX6: mx6qsabrelite: README: don't pass chip-select to sf probe command
Date: Wed, 03 Apr 2013 11:25:03 +0200 [thread overview]
Message-ID: <515BF56F.9050209@denx.de> (raw)
In-Reply-To: <1364228037-21962-1-git-send-email-javier.martinez@collabora.co.uk>
On 25/03/2013 17:13, Javier Martinez Canillas wrote:
> since commit "c1173bd0: sf command: allow default bus and chip selects"
> the chip-select and bus arguments for the sf probe command are optional.
>
Hi Javier,
> Even when passing the chip-select to sf probe says to be optional, it
> makes "sf erase" and "sf write" to fail on a mx6qsabrelite board. e.g:
>
> MX6QSABRELITE U-Boot > sf probe 1
> MX6QSABRELITE U-Boot > sf erase 0 0x40000
> SPI flash erase failed
> MX6QSABRELITE U-Boot > sf write 0x10800000 0 0x40000
> SPI flash write failed
Well, the real reason is that the passed chipselect is wrong. Checking
in the configuration file, I see that the value to be passed should be
0x7300. I suppose (I am not testing) that "sf probe 0x7300" make sf
erase and sw write working.
>
> But just using "sf probe" works well. So, update the mx6qsabrelite
> README so the commands will work on current U-Boot.
I agree with the patch, but the description is wrong. Can you rewrite it
simply stating that the chipselect "1" is wrong and that it is not
strictly required (but again, is not forbidden) to pass it to sf probe ?
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2013-04-03 9:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 16:13 [U-Boot] [PATCH 1/1] i.MX6: mx6qsabrelite: README: don't pass chip-select to sf probe command Javier Martinez Canillas
2013-04-03 9:25 ` Stefano Babic [this message]
2013-04-03 9:50 ` Javier Martinez Canillas
2013-04-03 10:13 ` Stefano Babic
2013-04-03 14:11 ` Eric Nelson
2013-04-03 14:49 ` Stefano Babic
2013-04-03 14:54 ` Eric Nelson
2013-04-03 14:06 ` Eric Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515BF56F.9050209@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox