public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5] ARM: vexpress: move files in preparation for adding a new platform
Date: Thu, 04 Apr 2013 12:30:30 +0200	[thread overview]
Message-ID: <515D5646.80409@linaro.org> (raw)
In-Reply-To: <20130404120634.4bffbce9@lilith>

On 04/04/2013 12:06 PM, Albert ARIBAUD wrote:
> Hi Andre,
>
> On Wed,  3 Apr 2013 15:44:32 +0200, Andre Przywara
> <andre.przywara@linaro.org> wrote:
>
>> From: Ryan Harkin <ryan.harkin@linaro.org>
>>
>> The current ca9x4_ct_vxp platform contains support for a Versatile Express
>> motherboard with a quad core A9 core tile.
>>
>> This patch is the first stage of making separating the Versatile Express
>> motherboard code and the A9 specific code, before adding support for the
>> dual core A5 core tile.
>>
>> Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>
>> Signed-off-by: Andre Przywara <andre.przywara@linaro.org>
>> ---
>>   MAINTAINERS                             |   2 +-
>>   board/armltd/vexpress/Makefile          |   2 +-
>>   board/armltd/vexpress/ca9x4_ct_vxp.c    | 257 --------------------------------
>>   board/armltd/vexpress/vexpress_common.c | 257 ++++++++++++++++++++++++++++++++
>>   boards.cfg                              |   2 +-
>>   include/configs/ca9x4_ct_vxp.h          | 198 ------------------------
>>   include/configs/vexpress_common.h       | 198 ++++++++++++++++++++++++
>>   7 files changed, 458 insertions(+), 458 deletions(-)
>>   delete mode 100644 board/armltd/vexpress/ca9x4_ct_vxp.c
>>   create mode 100644 board/armltd/vexpress/vexpress_common.c
>>   delete mode 100644 include/configs/ca9x4_ct_vxp.h
>>   create mode 100644 include/configs/vexpress_common.h
>
> This patch seems to not take moves into account, and rather, lists
> these as deletes/creates. Did you use git format-patch, and if so, did
> you use tne -M option?

Hi Albert!

Thanks for the -M hint, didn't know about it. Indeed it makes the 
patches more readable. Will use it in v2.

> Also, the commit summary could be less generic, something like "ARM:
> vexpress: rename board ca9x4_ct_vxp as vexpress_common".

OK, will fix this.

Thanks for the review,
Andre.

  reply	other threads:[~2013-04-04 10:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03 13:44 [U-Boot] [PATCH 0/5] ARM: vexpress: add support for more core tiles Andre Przywara
2013-04-03 13:44 ` [U-Boot] [PATCH 1/5] ARM: vexpress: move files in preparation for adding a new platform Andre Przywara
2013-04-04 10:06   ` Albert ARIBAUD
2013-04-04 10:30     ` Andre Przywara [this message]
2013-04-03 13:44 ` [U-Boot] [PATCH 2/5] ARM: vexpress: create A9 specific board config Andre Przywara
2013-04-04 10:09   ` Albert ARIBAUD
2013-04-04 10:31     ` Andre Przywara
2013-04-04 11:13       ` Albert ARIBAUD
2013-04-03 13:44 ` [U-Boot] [PATCH 3/5] ARM: vexpress: create A5 " Andre Przywara
2013-04-03 13:44 ` [U-Boot] [PATCH 4/5] ARM: vexpress: add support for Versatile Express Cortex-A15-TC2 Andre Przywara
2013-04-03 13:44 ` [U-Boot] [PATCH 5/5] ARM: vexpress: enable bootz and hush parser for all VExpress boards Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515D5646.80409@linaro.org \
    --to=andre.przywara@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox