From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Thu, 04 Apr 2013 15:29:35 +0200
Subject: [U-Boot] [PATCH] flash: Add optional verify-after-write feature
In-Reply-To: <20130404124623.CC8F82015BC@gemini.denx.de>
References: <1365059554-10662-1-git-send-email-sr@denx.de>
	<20130404124623.CC8F82015BC@gemini.denx.de>
Message-ID: <515D803F.9060303@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Wolfgang,

On 04.04.2013 14:46, Wolfgang Denk wrote:
> In message <1365059554-10662-1-git-send-email-sr@denx.de> you wrote:
>> Sometimes it might make sense to verify the written data to NOR flash.
>> This patch adds this feature. To enable this verify-after-write, you
>> need to define CONFIG_SYS_FLASH_VERIFY_AFTER_WRITE in your board
>> config header.
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> ---
>>  common/flash.c | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
> 
> This is a user selectable feature, thus the option should be
> CONFIG_FLASH_VERIFY_AFTER_WRITE.  Thinking about it - obviously you
> cannot verify _before_ the write, so all the "after write" is
> redundant.  Better call it just "CONFIG_FLASH_VERIFY".  Please also
> change the error message:
> 
> Instead
> 
> 	printf("\nVerify-after-write failed!\n");
> 
> just:
> 
> 	printf("\nVerify failed!\n");
> 
> Finally - you are introducing a new CONFIG_ option; this must be
> documented in the README.
> 
> And it might make sense to add a comment that this option is totally
> useless in almost all cases, and should only be enabled if you know
> EXACTLY what you are doing - and that it does not really work even
> then.

Thanks for your review. Everything you mentioned makes perfect sense.
I'll address those issues in v2 of the patch.

Thanks,
Stefan