From mboxrd@z Thu Jan 1 00:00:00 1970 From: York Sun Date: Thu, 4 Apr 2013 14:48:51 -0700 Subject: [U-Boot] [PATCH] CRITICAL error in v2013.04-rc2 (true and false not working) In-Reply-To: <20130404214736.0AC302015BE@gemini.denx.de> References: <201304041946.55455@pali> <20130404203307.266C02015BE@gemini.denx.de> <515DEB0E.7040709@freescale.com> <201304042319.39473@pali> <515DEED2.90908@freescale.com> <20130404214736.0AC302015BE@gemini.denx.de> Message-ID: <515DF543.7000801@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/04/2013 02:47 PM, Wolfgang Denk wrote: > Dear York Sun, > > In message <515DEED2.90908@freescale.com> you wrote: >> >> Would this fix be acceptable? > > No... > >> +#ifdef true >> +#undef true >> +#undef false >> + >> U_BOOT_CMD( >> false, CONFIG_SYS_MAXARGS, 1, do_false, >> "do nothing, unsuccessfully", >> @@ -171,3 +175,5 @@ U_BOOT_CMD( >> "do nothing, successfully", >> NULL >> ); >> + >> +#endif > > ... as it would completely remove the command entries if "true" was > not defined. > Right. I will go with Tom's suggestion. York