public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [v3] command/cache: Add flush command
Date: Fri, 5 Apr 2013 16:02:42 -0700	[thread overview]
Message-ID: <515F5812.8030008@freescale.com> (raw)
In-Reply-To: <20130405220955.DC9BB2015C6@gemini.denx.de>

On 04/05/2013 03:09 PM, Wolfgang Denk wrote:
> Dear York Sun,
> 
> In message <1365195056-20188-1-git-send-email-yorksun@freescale.com> you wrote:
>> When we copy code/data to the main memory, we may need to flush the
>> cache if required by architecture. It uses the existing function
>> flush_cache. Syntax is
>>
>> flush <addr> <size>
> 
> Plain "flush" is way too generic a name.  I think we should make it
> clear from the command invocation that we are dealing with caches
> here.
> 
> Actually I think we should not even use a new command for this - we
> already have the "dcahe" and "icache" commands for this purpose.
> 
> What do you think about implementiung this as a subcommand to
> "dcache"?  Something like:
> 
> So far:
> 
> 	dcache on
> 	dcache off
> 
> adding new:
> 
> 	dcache flush			=> flush all
> 	dcache flush <addr> <size>	=> flush range
> 
> I think this makes more sense.  Comments?
> 
>

It would if the command only deals with dcache. This command flushes
dcache _and_ invalidates icache.

If "flush_cache" is acceptable, we can use v2. If not, please suggest
one. My candidates are "flushcache", "cacheflush".

York

  reply	other threads:[~2013-04-05 23:02 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-05 20:50 [U-Boot] [v3] command/cache: Add flush command York Sun
2013-04-05 21:00 ` Tom Rini
2013-04-05 21:09   ` York Sun
2013-04-05 22:09 ` Wolfgang Denk
2013-04-05 23:02   ` York Sun [this message]
2013-04-06  7:01     ` Wolfgang Denk
2013-04-07  3:31       ` sun york-R58495
2013-04-07  8:29         ` Wolfgang Denk
2013-04-08 17:45           ` sun york-R58495
2013-04-08 18:35             ` Wolfgang Denk
2013-04-08 19:05               ` Scott Wood
2013-04-08 19:18                 ` Wolfgang Denk
2013-04-08 19:31                   ` Scott Wood
2013-04-09 17:45                     ` Wolfgang Denk
2013-04-10  0:58                       ` Scott Wood
2013-04-10  2:07                         ` [U-Boot] DWMMC / DWMCI question TigerLiu at viatech.com.cn
2013-04-10 11:58                           ` Wolfgang Denk
2013-04-11  1:43                             ` TigerLiu at viatech.com.cn
2013-04-10 11:54                         ` [U-Boot] [v3] command/cache: Add flush command Wolfgang Denk
2013-04-10 19:42                           ` Scott Wood
2013-04-10 21:04                             ` Wolfgang Denk
2013-04-10 21:10                               ` Scott Wood
2013-04-10 22:50                                 ` Wolfgang Denk
2013-04-10 23:00                                   ` Scott Wood
2013-04-11 11:56                                     ` Wolfgang Denk
2013-04-08 19:50           ` Scott Wood
2013-04-09 17:48             ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515F5812.8030008@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox