From mboxrd@z Thu Jan 1 00:00:00 1970 From: York Sun Date: Fri, 5 Apr 2013 16:02:42 -0700 Subject: [U-Boot] [v3] command/cache: Add flush command In-Reply-To: <20130405220955.DC9BB2015C6@gemini.denx.de> References: <1365195056-20188-1-git-send-email-yorksun@freescale.com> <20130405220955.DC9BB2015C6@gemini.denx.de> Message-ID: <515F5812.8030008@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/05/2013 03:09 PM, Wolfgang Denk wrote: > Dear York Sun, > > In message <1365195056-20188-1-git-send-email-yorksun@freescale.com> you wrote: >> When we copy code/data to the main memory, we may need to flush the >> cache if required by architecture. It uses the existing function >> flush_cache. Syntax is >> >> flush > > Plain "flush" is way too generic a name. I think we should make it > clear from the command invocation that we are dealing with caches > here. > > Actually I think we should not even use a new command for this - we > already have the "dcahe" and "icache" commands for this purpose. > > What do you think about implementiung this as a subcommand to > "dcache"? Something like: > > So far: > > dcache on > dcache off > > adding new: > > dcache flush => flush all > dcache flush => flush range > > I think this makes more sense. Comments? > > It would if the command only deals with dcache. This command flushes dcache _and_ invalidates icache. If "flush_cache" is acceptable, we can use v2. If not, please suggest one. My candidates are "flushcache", "cacheflush". York