From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix wrong >4G filtering
Date: Sun, 07 Apr 2013 17:33:54 +0200 [thread overview]
Message-ID: <516191E2.8040403@gmail.com> (raw)
Filtering of >4G chunks is wrong and one of such chunks can be improperly declared
as usable ram top after being cut down to 4G, so uboot tries to relocate to ROM.
diff --git a/arch/x86/cpu/coreboot/sdram.c b/arch/x86/cpu/coreboot/sdram.c
index 786009c..3b8dd5e 100644
--- a/arch/x86/cpu/coreboot/sdram.c
+++ b/arch/x86/cpu/coreboot/sdram.c
@@ -77,8 +77,11 @@ ulong board_get_usable_ram_top(ulong total_size)
continue;
/* Filter memory over 4GB. */
+ if (start > 0xffffffffULL)
+ continue;
if (end > 0xffffffffULL)
- end = 0x100000000ULL;
+ end = 0xffffffffULL;
+
/* Skip this region if it's too small. */
if (end - start < total_size)
continue;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 294 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130407/3ed956bc/attachment.pgp>
next reply other threads:[~2013-04-07 15:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 15:33 Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2013-04-15 23:51 ` [U-Boot] [PATCH] Fix wrong >4G filtering Simon Glass
2013-04-16 20:03 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516191E2.8040403@gmail.com \
--to=phcoder@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox