* [U-Boot] [PATCH] Fix wrong >4G filtering
@ 2013-04-07 15:33 Vladimir 'φ-coder/phcoder' Serbinenko
2013-04-15 23:51 ` Simon Glass
0 siblings, 1 reply; 3+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2013-04-07 15:33 UTC (permalink / raw)
To: u-boot
Filtering of >4G chunks is wrong and one of such chunks can be improperly declared
as usable ram top after being cut down to 4G, so uboot tries to relocate to ROM.
diff --git a/arch/x86/cpu/coreboot/sdram.c b/arch/x86/cpu/coreboot/sdram.c
index 786009c..3b8dd5e 100644
--- a/arch/x86/cpu/coreboot/sdram.c
+++ b/arch/x86/cpu/coreboot/sdram.c
@@ -77,8 +77,11 @@ ulong board_get_usable_ram_top(ulong total_size)
continue;
/* Filter memory over 4GB. */
+ if (start > 0xffffffffULL)
+ continue;
if (end > 0xffffffffULL)
- end = 0x100000000ULL;
+ end = 0xffffffffULL;
+
/* Skip this region if it's too small. */
if (end - start < total_size)
continue;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 294 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130407/3ed956bc/attachment.pgp>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] Fix wrong >4G filtering
2013-04-07 15:33 [U-Boot] [PATCH] Fix wrong >4G filtering Vladimir 'φ-coder/phcoder' Serbinenko
@ 2013-04-15 23:51 ` Simon Glass
2013-04-16 20:03 ` Simon Glass
0 siblings, 1 reply; 3+ messages in thread
From: Simon Glass @ 2013-04-15 23:51 UTC (permalink / raw)
To: u-boot
On Sun, Apr 7, 2013 at 8:33 AM, Vladimir '?-coder/phcoder' Serbinenko
<phcoder@gmail.com> wrote:
> Filtering of >4G chunks is wrong and one of such chunks can be improperly declared
> as usable ram top after being cut down to 4G, so uboot tries to relocate to ROM.
>
With commit message re-formatted to 80cols, applied to x86/master, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] Fix wrong >4G filtering
2013-04-15 23:51 ` Simon Glass
@ 2013-04-16 20:03 ` Simon Glass
0 siblings, 0 replies; 3+ messages in thread
From: Simon Glass @ 2013-04-16 20:03 UTC (permalink / raw)
To: u-boot
+Tom
Hi Vladimir,
On Mon, Apr 15, 2013 at 4:51 PM, Simon Glass <sjg@chromium.org> wrote:
> On Sun, Apr 7, 2013 at 8:33 AM, Vladimir '?-coder/phcoder' Serbinenko
> <phcoder@gmail.com> wrote:
>> Filtering of >4G chunks is wrong and one of such chunks can be improperly declared
>> as usable ram top after being cut down to 4G, so uboot tries to relocate to ROM.
>>
>
> With commit message re-formatted to 80cols, applied to x86/master, thank you.
My mistake - this is missing a signoff, and also should not have a
Nickname in your email.
Can you please resend this patch with these problems fixed?
Regards,
Simon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-16 20:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-07 15:33 [U-Boot] [PATCH] Fix wrong >4G filtering Vladimir 'φ-coder/phcoder' Serbinenko
2013-04-15 23:51 ` Simon Glass
2013-04-16 20:03 ` Simon Glass
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox