From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] mmc: sdhci: Add a quirk to add delay during completion of sdhci_send_cmd
Date: Tue, 09 Apr 2013 18:53:18 +0900 [thread overview]
Message-ID: <5163E50E.7050609@samsung.com> (raw)
In-Reply-To: <CAD6G_RRyDm8SbWQWTRcGHAF7jm72mi2H_ymACMJfGkc2C3TWbg@mail.gmail.com>
On 04/09/2013 06:41 PM, Jagan Teki wrote:
> Hi Tushar,
>
> On Mon, Apr 8, 2013 at 9:22 AM, Tushar Behera <tushar.behera@linaro.org> wrote:
>> On 04/07/2013 10:27 AM, Jagan Teki wrote:
>>> Hi,
>>>
>>> I saw that you have been added the SDHCI_QUIRK_WAIT_SEND_CMD on below commit
>>> http://git.denx.de/?p=u-boot.git;a=commitdiff;h=13243f2eafc4292917178051fe1bb5aab2774dca
>>>
>>> I need few quires regarding the QUIRK delay.
>>> 1. Why the delay is 1000
>>> + if (host->quirks & SDHCI_QUIRK_WAIT_SEND_CMD)
>>> + udelay(1000);
>>> +
>>> 2. is this delay specific to s5p_sdhci controller?
>>
>
> BTW:
> Can you please help me out what is the reason for max and min clocks
> are at 52000000 and 400000 respectively.
>
> As per my knowledge the max clock of sdhci on spec-2 is 50000000
> (50Mhz), I may be in correct.
Right..But eMMC can use up to 52MHz.
And see into the drivers/mmc/mmc.c..SD-card's max_dtr is set to 50MHz, if card is supported HS_MODE.
>
> Request for your help.
>
> Thanks,
> Jagan.
>
>> This was specific to s5p_sdhci driver so as to replicate the behavior of
>> s5p_mmc driver.
>>
>>> 3. I have an issue "Controller never released inhibit bit(s)"
>>> but when I enable this quirk on my driver with udelay(10000), it's
>>> working.
>>
>> I am not sure about the exact delay as per the spec. I have added
>> Jaehoon to CC who might have additional information about this.
>>
>>>
>>> Could you please help me.
>>>
>>> Thanks,
>>> Jagan.
>>>
>>
>>
>> --
>> Tushar Behera
>
next prev parent reply other threads:[~2013-04-09 9:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 4:57 [U-Boot] mmc: sdhci: Add a quirk to add delay during completion of sdhci_send_cmd Jagan Teki
2013-04-08 3:52 ` Tushar Behera
2013-04-08 4:07 ` Jaehoon Chung
2013-04-08 7:35 ` Lukasz Majewski
2013-04-08 17:58 ` Jagan Teki
2013-04-09 9:41 ` Jagan Teki
2013-04-09 9:53 ` Jaehoon Chung [this message]
2013-04-09 10:34 ` Jagan Teki
-- strict thread matches above, loose matches on Subject: below --
2013-04-06 10:15 Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5163E50E.7050609@samsung.com \
--to=jh80.chung@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox