public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Dunn <mikedunn@newsguy.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/8] pxa_lcd: allow L_BIAS line to be unused
Date: Tue, 09 Apr 2013 10:02:44 -0700	[thread overview]
Message-ID: <516449B4.3010706@newsguy.com> (raw)
In-Reply-To: <201304080728.06230.marex@denx.de>

On 04/07/2013 10:28 PM, Marek Vasut wrote:
> Dear Mike Dunn,
> 
>> This patch adds a config option CONFIG_SYS_LCD_PXA_NO_L_BIAS, which causes
>> the lcd controller initialization code to leave as an ordinary gpio the
>> line that is typically configured as the lcd L_BIAS alternate function
>> (this is the gpio 77 line).
>>
>> For some reason (I don't have a datasheet), the lcd device on the
>> palmtreo680 board does not use the L_BIAS line.  PalmOS does not configure
>> the gpio 77 line for the L_BIAS alternate function, and if it is
>> configured as such, the lcd does not work.
>>
>> Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
> 
> The other option would be to pull the GPIO setup from the driver. That'd be the 
> best.


Well, there's a lot of shared code in pxafb_setup_gpio() that handles pin
configuration for all possible interface widths.

But after looking at this problem some more, I realized that the board-specific
lcd_enable() is called after the pxa driver's initialization, so the board code
can undo the L_BIAS pin configuration.  Not elegant, but better than the ugly
#ifdefs.

Thanks,
Mike

  reply	other threads:[~2013-04-09 17:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-07 16:40 [U-Boot] [PATCH 0/8] palm treo 680 smartphone board support Mike Dunn
2013-04-07 16:40 ` [U-Boot] [PATCH 1/8] pxa_lcd: add the ACX544AKN lcd device Mike Dunn
2013-04-07 16:40 ` [U-Boot] [PATCH 2/8] pxa_lcd: make lcd_enable() a weak pointer Mike Dunn
2013-04-07 19:08   ` Fabio Estevam
2013-04-08 17:49     ` Mike Dunn
2013-04-07 16:41 ` [U-Boot] [PATCH 3/8] pxa_lcd: allow L_BIAS line to be unused Mike Dunn
2013-04-08  5:28   ` Marek Vasut
2013-04-09 17:02     ` Mike Dunn [this message]
2013-04-07 16:41 ` [U-Boot] [PATCH 4/8] pxa27x_udc: remove call to unimplemented set_GPIO_mode() Mike Dunn
2013-04-07 16:41 ` [U-Boot] [PATCH 5/8] arm: bootm: call udc_disable() before booting linux Mike Dunn
2013-04-08  5:29   ` Marek Vasut
2013-04-07 16:41 ` [U-Boot] [PATCH 6/8] lib: import bitrev library from linux kernel Mike Dunn
2013-04-08  6:23   ` Marek Vasut
2013-04-08 16:46     ` Mike Dunn
2013-04-08  7:38   ` Wolfgang Denk
2013-04-07 16:41 ` [U-Boot] [PATCH 7/8] mtd: nand: add driver for diskonchip g4 nand flash Mike Dunn
2013-04-08  6:25   ` Marek Vasut
2013-04-08 17:10     ` Mike Dunn
2013-04-08 17:26       ` Marek Vasut
2013-04-09  0:59     ` Scott Wood
2013-04-09 15:36       ` Mike Dunn
2013-04-07 16:41 ` [U-Boot] [PATCH 8/8] board support for palm treo 680 Mike Dunn
2013-04-08  6:27   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516449B4.3010706@newsguy.com \
    --to=mikedunn@newsguy.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox