From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mx35 iomux: correct offsets of IOMUX registers
Date: Wed, 10 Apr 2013 08:23:11 +0200 [thread overview]
Message-ID: <5165054F.7020209@denx.de> (raw)
In-Reply-To: <1365547471-5071-1-git-send-email-philip@paeps.cx>
On 10/04/2013 00:44, Philip Paeps wrote:
> This makes mxc_iomux_set_input() work correctly. Previously, the
> incorrect offset of IOMUXSW_INPUT_CTL caused mxc_iomux_set_input()
> to write to the wrong register, possibly resulting in unexpected
> behaviour.
>
> Signed-off-by: Philip Paeps <philip@paeps.cx>
> ---
Hi Philip,
> Changes in v2:
> - While here, also correct the offset of the last pad control
> register. This is mostly cosmetic.
>
> arch/arm/cpu/arm1136/mx35/iomux.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/cpu/arm1136/mx35/iomux.c b/arch/arm/cpu/arm1136/mx35/iomux.c
> index a302575..698909e 100644
> --- a/arch/arm/cpu/arm1136/mx35/iomux.c
> +++ b/arch/arm/cpu/arm1136/mx35/iomux.c
> @@ -34,8 +34,8 @@ enum iomux_reg_addr {
> IOMUXSW_MUX_CTL = IOMUXC_BASE_ADDR + 4, /* MUX control */
> IOMUXSW_MUX_END = IOMUXC_BASE_ADDR + 0x324, /* last MUX control */
> IOMUXSW_PAD_CTL = IOMUXC_BASE_ADDR + 0x328, /* Pad control */
> - IOMUXSW_PAD_END = IOMUXC_BASE_ADDR + 0x794, /* last Pad control */
> - IOMUXSW_INPUT_CTL = IOMUXC_BASE_ADDR + 0x7AC, /* input select */
> + IOMUXSW_PAD_END = IOMUXC_BASE_ADDR + 0x7A4, /* last Pad control */
> + IOMUXSW_INPUT_CTL = IOMUXC_BASE_ADDR + 0x7A8, /* input select */
> IOMUXSW_INPUT_END = IOMUXC_BASE_ADDR + 0x9F4, /* last input select */
> };
You're right, offset were wrong.
Acked-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2013-04-10 6:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 21:29 [U-Boot] [PATCH] mx35 iomux: correct offset of IOMUXSW_INPUT_CTL register Philip Paeps
2013-04-09 22:44 ` [U-Boot] [PATCH v2] mx35 iomux: correct offsets of IOMUX registers Philip Paeps
2013-04-10 6:23 ` Stefano Babic [this message]
2013-04-16 11:01 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5165054F.7020209@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox