From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Wed, 10 Apr 2013 08:23:11 +0200 Subject: [U-Boot] [PATCH v2] mx35 iomux: correct offsets of IOMUX registers In-Reply-To: <1365547471-5071-1-git-send-email-philip@paeps.cx> References: <1365542946-4360-1-git-send-email-philip@paeps.cx> <1365547471-5071-1-git-send-email-philip@paeps.cx> Message-ID: <5165054F.7020209@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/04/2013 00:44, Philip Paeps wrote: > This makes mxc_iomux_set_input() work correctly. Previously, the > incorrect offset of IOMUXSW_INPUT_CTL caused mxc_iomux_set_input() > to write to the wrong register, possibly resulting in unexpected > behaviour. > > Signed-off-by: Philip Paeps > --- Hi Philip, > Changes in v2: > - While here, also correct the offset of the last pad control > register. This is mostly cosmetic. > > arch/arm/cpu/arm1136/mx35/iomux.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/cpu/arm1136/mx35/iomux.c b/arch/arm/cpu/arm1136/mx35/iomux.c > index a302575..698909e 100644 > --- a/arch/arm/cpu/arm1136/mx35/iomux.c > +++ b/arch/arm/cpu/arm1136/mx35/iomux.c > @@ -34,8 +34,8 @@ enum iomux_reg_addr { > IOMUXSW_MUX_CTL = IOMUXC_BASE_ADDR + 4, /* MUX control */ > IOMUXSW_MUX_END = IOMUXC_BASE_ADDR + 0x324, /* last MUX control */ > IOMUXSW_PAD_CTL = IOMUXC_BASE_ADDR + 0x328, /* Pad control */ > - IOMUXSW_PAD_END = IOMUXC_BASE_ADDR + 0x794, /* last Pad control */ > - IOMUXSW_INPUT_CTL = IOMUXC_BASE_ADDR + 0x7AC, /* input select */ > + IOMUXSW_PAD_END = IOMUXC_BASE_ADDR + 0x7A4, /* last Pad control */ > + IOMUXSW_INPUT_CTL = IOMUXC_BASE_ADDR + 0x7A8, /* input select */ > IOMUXSW_INPUT_END = IOMUXC_BASE_ADDR + 0x9F4, /* last input select */ > }; You're right, offset were wrong. Acked-by: Stefano Babic Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================